Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IAST benchmarks #3193

Merged
merged 3 commits into from
Jun 19, 2023
Merged

Add IAST benchmarks #3193

merged 3 commits into from
Jun 19, 2023

Conversation

uurien
Copy link
Collaborator

@uurien uurien commented May 26, 2023

What does this PR do?

Executes and compares with master benchmark tests with DD_IAST_ENABLED.

Motivation

Make sure that we are not adding regressions in the PRs

@github-actions
Copy link

github-actions bot commented May 26, 2023

Overall package size

Self size: 4.36 MB
Deduped: 60.72 MB
No deduping: 60.76 MB

Dependency sizes

name version self size total size
@datadog/pprof 2.2.1 14.24 MB 15.12 MB
@datadog/native-iast-taint-tracking 1.5.0 14.86 MB 14.86 MB
@datadog/native-appsec 3.2.0 13.38 MB 13.39 MB
protobufjs 7.1.2 2.76 MB 6.55 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
@opentelemetry/core 1.3.1 784.66 kB 1.37 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.3.8 88.2 kB 118.6 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.5 34.34 kB 38.81 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #3193 (a714dde) into master (839a6f8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3193   +/-   ##
=======================================
  Coverage   86.02%   86.02%           
=======================================
  Files         194      194           
  Lines        7514     7514           
  Branches       33       33           
=======================================
  Hits         6464     6464           
  Misses       1050     1050           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pr-commenter
Copy link

pr-commenter bot commented May 26, 2023

Benchmarks

Comparing candidate commit a714dde in PR branch ugaitz/iast-benchmark with baseline commit 839a6f8 in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 406 metrics, 25 unstable metrics.

scenario:log-without-log-18

  • 🟥 execution_time [+10.379ms; +13.441ms] or [+5.317%; +6.886%]

@uurien uurien force-pushed the ugaitz/iast-benchmark branch 3 times, most recently from 8801411 to b2b4810 Compare May 30, 2023 15:32
@uurien uurien changed the title [WIP] Add IAST benchmarks Add IAST benchmarks May 30, 2023
@uurien uurien force-pushed the ugaitz/iast-benchmark branch 2 times, most recently from 7d09eac to 61b3819 Compare June 9, 2023 09:33
@uurien uurien marked this pull request as ready for review June 9, 2023 09:36
@uurien uurien requested a review from a team as a code owner June 9, 2023 09:36
simon-id
simon-id previously approved these changes Jun 12, 2023
Copy link
Member

@simon-id simon-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure env vars are applied correctly and test the thing altogether, then LGTM

@uurien uurien force-pushed the ugaitz/iast-benchmark branch 5 times, most recently from 0e4526c to 4cd3313 Compare June 14, 2023 14:21
@simon-id simon-id marked this pull request as draft June 14, 2023 16:56
@simon-id
Copy link
Member

I put the PR back in draft if that's ok with you

@uurien uurien force-pushed the ugaitz/iast-benchmark branch 3 times, most recently from 3a13966 to aa620bf Compare June 15, 2023 07:20
@uurien uurien force-pushed the ugaitz/iast-benchmark branch 2 times, most recently from db4404c to 0301193 Compare June 19, 2023 07:52
benchmark/sirun/appsec-iast/README.md Outdated Show resolved Hide resolved
benchmark/sirun/appsec-iast/common.js Outdated Show resolved Hide resolved
benchmark/sirun/appsec-iast/meta.json Show resolved Hide resolved
uurien and others added 2 commits June 19, 2023 12:16
Co-authored-by: simon-id <simon.id@datadoghq.com>
@uurien uurien marked this pull request as ready for review June 19, 2023 11:04
@uurien uurien requested a review from simon-id June 19, 2023 13:52
@uurien uurien merged commit f3e4ce8 into master Jun 19, 2023
nsavoire pushed a commit that referenced this pull request Jun 20, 2023
* appsec-iast benchmark tests

* writing fixes

Co-authored-by: simon-id <simon.id@datadoghq.com>

* small fixes

---------

Co-authored-by: simon-id <simon.id@datadoghq.com>
nsavoire pushed a commit that referenced this pull request Jun 20, 2023
* appsec-iast benchmark tests

* writing fixes

Co-authored-by: simon-id <simon.id@datadoghq.com>

* small fixes

---------

Co-authored-by: simon-id <simon.id@datadoghq.com>
nsavoire pushed a commit that referenced this pull request Jun 21, 2023
* appsec-iast benchmark tests

* writing fixes

Co-authored-by: simon-id <simon.id@datadoghq.com>

* small fixes

---------

Co-authored-by: simon-id <simon.id@datadoghq.com>
This was referenced Jun 21, 2023
tlhunter pushed a commit that referenced this pull request Jun 23, 2023
* appsec-iast benchmark tests

* writing fixes

Co-authored-by: simon-id <simon.id@datadoghq.com>

* small fixes

---------

Co-authored-by: simon-id <simon.id@datadoghq.com>
tlhunter pushed a commit that referenced this pull request Jun 23, 2023
* appsec-iast benchmark tests

* writing fixes

Co-authored-by: simon-id <simon.id@datadoghq.com>

* small fixes

---------

Co-authored-by: simon-id <simon.id@datadoghq.com>
tlhunter pushed a commit that referenced this pull request Jun 23, 2023
* appsec-iast benchmark tests

* writing fixes

Co-authored-by: simon-id <simon.id@datadoghq.com>

* small fixes

---------

Co-authored-by: simon-id <simon.id@datadoghq.com>
@tlhunter tlhunter deleted the ugaitz/iast-benchmark branch January 19, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants