-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MySQL databases - service naming #3057
Conversation
Overall package sizeSelf size: 4.32 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #3057 +/- ##
==========================================
- Coverage 86.05% 85.67% -0.39%
==========================================
Files 191 182 -9
Lines 7459 7239 -220
Branches 33 33
==========================================
- Hits 6419 6202 -217
+ Misses 1040 1037 -3
... and 24 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
84eab80
to
10386ae
Compare
10386ae
to
7d63b43
Compare
3bde47b
to
ccada49
Compare
7d63b43
to
3744c6a
Compare
3744c6a
to
1a79692
Compare
1a79692
to
33a4eb9
Compare
33a4eb9
to
86a2b54
Compare
* add v0 naming to mysql integrations * add v1 to mysql integrations * add tests on v1 for mysql databases --------- Co-authored-by: Thomas Hunter II <tlhunter@datadog.com>
* add v0 naming to mysql integrations * add v1 to mysql integrations * add tests on v1 for mysql databases --------- Co-authored-by: Thomas Hunter II <tlhunter@datadog.com>
* add v0 naming to mysql integrations * add v1 to mysql integrations * add tests on v1 for mysql databases --------- Co-authored-by: Thomas Hunter II <tlhunter@datadog.com>
* add v0 naming to mysql integrations * add v1 to mysql integrations * add tests on v1 for mysql databases --------- Co-authored-by: Thomas Hunter II <tlhunter@datadog.com>
* add v0 naming to mysql integrations * add v1 to mysql integrations * add tests on v1 for mysql databases --------- Co-authored-by: Thomas Hunter II <tlhunter@datadog.com>
* add v0 naming to mysql integrations * add v1 to mysql integrations * add tests on v1 for mysql databases --------- Co-authored-by: Thomas Hunter II <tlhunter@datadog.com>
What does this PR do?
This applies the service naming schema logic (see #2941) to mysql integrations -
mysql
,mysql2
andmariadb
.These are more complex than messaging integrations, as we need to take into account the default provided by DatabasePlugin into the naming functions, which version 0 must respect, but version 1 does not need.
This PR relies on #3056 for the split into different files according to general area (messaging, storage) and a few optimizations to the service naming computation.
Motivation
Keep trucking on naming schema adoption.
Plugin Checklist
Additional Notes