-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test in shimmer wrap to preserve function name #3237
Conversation
Overall package sizeSelf size: 4.31 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #3237 +/- ##
===========================================
+ Coverage 68.16% 86.06% +17.89%
===========================================
Files 184 190 +6
Lines 6990 7450 +460
Branches 33 33
===========================================
+ Hits 4765 6412 +1647
+ Misses 2225 1038 -1187 see 60 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Could it worth adding a test for class?
|
@uurien eh, i'd say if one works there is no reason the other doesn't |
What does this PR do?
Just add a small test to make sure function names are preserved in shimmer.js