Tedious - service naming #3061
Merged
Tedious - service naming #3061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overall package sizeSelf size: 4.25 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #3061 +/- ##
=======================================
Coverage 85.72% 85.73%
=======================================
Files 182 182
Lines 7229 7232 +3
Branches 33 33
=======================================
+ Hits 6197 6200 +3
Misses 1032 1032
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tlhunter
reviewed
May 1, 2023
amarziali
reviewed
May 3, 2023
jbertran
force-pushed
the
jbertran/service-naming-tedious
branch
from
1845a9a
to
1fbc04f
Compare
jbertran
force-pushed
the
jbertran/service-naming-cache
branch
from
aeeefde
to
e825de4
Compare
jbertran
force-pushed
the
jbertran/service-naming-tedious
branch
from
1fbc04f
to
281c03c
Compare
jbertran
force-pushed
the
jbertran/service-naming-cache
branch
2 times, most recently
from
3bde47b
to
ccada49
Compare
jbertran
force-pushed
the
jbertran/service-naming-tedious
branch
2 times, most recently
from
bdb0fe9
to
97181b7
Compare
added 3 commits
June 8, 2023 18:30
The standard mssql server image does not work on ARM [1]. Instead, we use `azure-sql-edge` [2], which provides a sufficient subset of mssql server API to test most of our integration. Unfortunately, this image does not support stored procedures [3], so tests related to these will still fail locally. [1] microsoft/mssql-docker#668 [2] https://hub.docker.com/_/microsoft-azure-sql-edge [3] https://learn.microsoft.com/en-us/azure/azure-sql-edge/features#unsupported-features
jbertran
force-pushed
the
jbertran/service-naming-tedious
branch
from
97181b7
to
0e28f1c
Compare
tlhunter
approved these changes
Jun 14, 2023
nsavoire
pushed a commit
that referenced
this pull request
Jun 20, 2023
* add v0 naming to tedious (mssql) * add v1 naming to tedious (mssql) * switch to a mostly working test sqlserver The standard mssql server image does not work on ARM [1]. Instead, we use `azure-sql-edge` [2], which provides a sufficient subset of mssql server API to test most of our integration. Unfortunately, this image does not support stored procedures [3], so tests related to these will still fail locally. [1] microsoft/mssql-docker#668 [2] https://hub.docker.com/_/microsoft-azure-sql-edge [3] https://learn.microsoft.com/en-us/azure/azure-sql-edge/features#unsupported-features
nsavoire
pushed a commit
that referenced
this pull request
Jun 20, 2023
* add v0 naming to tedious (mssql) * add v1 naming to tedious (mssql) * switch to a mostly working test sqlserver The standard mssql server image does not work on ARM [1]. Instead, we use `azure-sql-edge` [2], which provides a sufficient subset of mssql server API to test most of our integration. Unfortunately, this image does not support stored procedures [3], so tests related to these will still fail locally. [1] microsoft/mssql-docker#668 [2] https://hub.docker.com/_/microsoft-azure-sql-edge [3] https://learn.microsoft.com/en-us/azure/azure-sql-edge/features#unsupported-features
nsavoire
pushed a commit
that referenced
this pull request
Jun 21, 2023
* add v0 naming to tedious (mssql) * add v1 naming to tedious (mssql) * switch to a mostly working test sqlserver The standard mssql server image does not work on ARM [1]. Instead, we use `azure-sql-edge` [2], which provides a sufficient subset of mssql server API to test most of our integration. Unfortunately, this image does not support stored procedures [3], so tests related to these will still fail locally. [1] microsoft/mssql-docker#668 [2] https://hub.docker.com/_/microsoft-azure-sql-edge [3] https://learn.microsoft.com/en-us/azure/azure-sql-edge/features#unsupported-features
This was referenced Jun 21, 2023
Merged
Merged
Merged
tlhunter
pushed a commit
that referenced
this pull request
Jun 23, 2023
* add v0 naming to tedious (mssql) * add v1 naming to tedious (mssql) * switch to a mostly working test sqlserver The standard mssql server image does not work on ARM [1]. Instead, we use `azure-sql-edge` [2], which provides a sufficient subset of mssql server API to test most of our integration. Unfortunately, this image does not support stored procedures [3], so tests related to these will still fail locally. [1] microsoft/mssql-docker#668 [2] https://hub.docker.com/_/microsoft-azure-sql-edge [3] https://learn.microsoft.com/en-us/azure/azure-sql-edge/features#unsupported-features
tlhunter
pushed a commit
that referenced
this pull request
Jun 23, 2023
* add v0 naming to tedious (mssql) * add v1 naming to tedious (mssql) * switch to a mostly working test sqlserver The standard mssql server image does not work on ARM [1]. Instead, we use `azure-sql-edge` [2], which provides a sufficient subset of mssql server API to test most of our integration. Unfortunately, this image does not support stored procedures [3], so tests related to these will still fail locally. [1] microsoft/mssql-docker#668 [2] https://hub.docker.com/_/microsoft-azure-sql-edge [3] https://learn.microsoft.com/en-us/azure/azure-sql-edge/features#unsupported-features
tlhunter
pushed a commit
that referenced
this pull request
Jun 23, 2023
* add v0 naming to tedious (mssql) * add v1 naming to tedious (mssql) * switch to a mostly working test sqlserver The standard mssql server image does not work on ARM [1]. Instead, we use `azure-sql-edge` [2], which provides a sufficient subset of mssql server API to test most of our integration. Unfortunately, this image does not support stored procedures [3], so tests related to these will still fail locally. [1] microsoft/mssql-docker#668 [2] https://hub.docker.com/_/microsoft-azure-sql-edge [3] https://learn.microsoft.com/en-us/azure/azure-sql-edge/features#unsupported-features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This applies the service naming schema logic (see #2941) to
tedious.This PR relies on #3056 for the split into different files according to general area (messaging, storage) and a few optimizations to the service naming computation.
Motivation
Keep trucking on naming schema adoption.
Plugin Checklist
Additional Notes