Hotfix/failing thin pull requests practice

[adelkahomolova]

Fix failing practice

[prokopsimek]

DX Scanner Report

https://github.com/DXHeroes/dx-scanner

⚠️ Improvements with medium impact

Break down large pull requests into smaller ones

Large pull request are hard to code review and it reduces the probability of finding bugs. Split your PRs into logical units. Do not have PR with more than 1000 changes. https://medium.com/@hugooodias/the-anatomy-of-a-perfect-pull-request-567382bb6067

Solve Issues Continuously

Do not have an open Issues more than 60 days. Solve Issues continuously. https://hackernoon.com/45-github-issues-dos-and-donts-dfec9ab4b612

Update Dependencies of Minor and Patch Level

Keep the dependencies updated to eliminate security concerns and compatibility issues. Use, for example, npm-check-updates. https://github.com/tjunnone/npm-check-updates

Name	New	Current
@types/node	13.1.8	12.12.25

Impact changed from high to medium.

ESLint Without Errors

Use the ESLint correctly. You have some errors. https://eslint.org/

🔔 Improvements with minor impact

Write Commit Messages by Convention

https://www.conventionalcommits.org/

Commit Message	Problems
Test/increase codecoverage (#204)	subject may not be empty; type may not be empty

                                                          |                                                                        

Test/increase codecoverage |
docs: Travis badge uses a master branch to show build status | subject must not be sentence-case, start-case, pascal-case, upper-case

Update Dependencies of Major Level

Keep the dependencies updated to have all possible features. Use, for example, npm-check-updates. https://github.com/tjunnone/npm-check-updates

Name	New	Current
@types/node	13.1.8	12.12.25

Use a JS Logging Library

Use a logging library to avoid errors and even cyber attacks. The most widely used logging library in the JavaScript community is Winston. https://www.npmjs.com/package/winston/

---

Implementation is not adoption.
We can help you with both. :-)
dxheroes.io

Found a bug? Please report.

[prokopsimek]

• change the suggestion text as the comment says
• add info about suggested changes of PR id attr

[prokopsimek]

How do you know that number attribute is an PR id?

• Add a link referring to the information why the number is the correct PR id.

I have found just this:

Be aware that the id of a pull request returned from "Issues" endpoints will be an issue id. To find out the pull request id, use the "List pull requests" endpoint.

src.: https://developer.github.com/v3/issues/#list-issues
... but nothing about the number attribute.

[codecov-io]

Codecov Report

Merging #207 into master will increase coverage by 0.19%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
+ Coverage   87.18%   87.38%   +0.19%     
==========================================
  Files         165      164       -1     
  Lines        3590     3559      -31     
  Branches      563      558       -5     
==========================================
- Hits         3130     3110      -20     
+ Misses        460      449      -11

Impacted Files	Coverage Δ
...detectors/JavaScript/JavaScriptLanguageDetector.ts	100% <ø> (ø)	⬆️
src/practices/index.ts	100% <ø> (ø)	⬆️
...__/bitbucketServiceMockFolder/getIssuesResponse.ts	100% <ø> (ø)	⬆️
src/detectors/utils.ts	100% <ø> (+8.57%)	⬆️
src/services/git/index.ts	100% <ø> (ø)	⬆️
src/contexts/scanner/ScannerContext.ts	100% <100%> (+5.55%)	⬆️
src/services/git/VCSServicesUtils.ts	83.33% <100%> (ø)	⬆️
... and 2 more

[prokopsimek]

🎉 This PR is included in version 1.35.3 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀