Test/increase codecoverage #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test/increase-codecoverage
Codecov Report
@@ Coverage Diff @@
## master #204 +/- ##
==========================================
+ Coverage 86.81% 87.38% +0.56%
==========================================
Files 165 164 -1
Lines 3572 3559 -13
Branches 558 558
==========================================
+ Hits 3101 3110 +9
+ Misses 471 449 -22
|
DX Scanner Report
https://github.com/DXHeroes/dx-scanner
|
| Name | New | Current |
|---|---|---|
| @commitlint/lint | 8.3.5 | 8.3.4 |
| memfs | 3.0.4 | 3.0.3 |
| ts-node | 8.6.2 | 8.6.1 |
| @types/node | 13.1.7 | 12.12.24 |
| semantic-release | 16.0.2 | 16.0.1 |
| @types/jest | 24.9.0 | 24.0.25 |
| @typescript-eslint/eslint-plugin | 2.16.0 | 2.15.0 |
| @typescript-eslint/parser | 2.16.0 | 2.15.0 |
Impact changed from high to medium.
ESLint Without Errors
Use the ESLint correctly. You have some errors. https://eslint.org/
🔔 Improvements with minor impact
Write Commit Messages by Convention
https://www.conventionalcommits.org/
| Commit Message | Problems |
|---|---|
| docs: Travis badge uses a master branch to show build status | subject must not be sentence-case, start-case, pascal-case, upper-case |
| chore: use listIssueComments for GitHub to list comments for a pull request | header must not be longer than 72 characters, current length is 75 |
Update Dependencies of Major Level
Keep the dependencies updated to have all possible features. Use, for example, npm-check-updates. https://github.com/tjunnone/npm-check-updates
| Name | New | Current |
|---|---|---|
| @types/node | 13.1.7 | 12.12.24 |
Use a JS Logging Library
Use a logging library to avoid errors and even cyber attacks. The most widely used logging library in the JavaScript community is Winston. https://www.npmjs.com/package/winston/
Implementation is not adoption.
We can help you with both. :-)
dxheroes.io
Found a bug? Please report.
…test/increase-codecoverage
…test/increase-codecoverage
prokopsimek
requested changes
Jan 16, 2020
src/inspectors/FileInspector.spec.ts
Outdated
Comment on lines
18
to
54
| // beforeEach(() => { | ||
| // virtualFileSystemService = new FileSystemService({ isVirtual: true }); | ||
| // fileInspector = new FileInspector(virtualFileSystemService, '/'); | ||
| // }); | ||
|
|
||
| afterEach(async () => { | ||
| containerCtx.virtualFileSystemService.clearFileSystem(); | ||
| containerCtx.practiceContext.fileInspector!.purgeCache(); | ||
| }); | ||
|
|
||
| it('Throws an error if the file does not exist', async () => { | ||
| const path = './'; | ||
| // const structure: DirectoryJSON = { | ||
| // '/index.cpp': '...', | ||
| // }; | ||
|
|
||
| // virtualFileSystemService.setFileSystem(structure); | ||
| try { | ||
| await fileInspector.scanFor('not.exist', path); | ||
| fail(); | ||
| } catch (error) { | ||
| expect(error.message).toEqual(`ENOENT: no such file or directory, readdir '${path}'`); | ||
| } | ||
| // expect(async () => { | ||
| // await fileInspector.scanFor('not.exist', path); | ||
| // }).toThrow(); | ||
| }); | ||
|
|
||
| // it('Returns practicing if there is a .gitignore', async () => { | ||
| // const structure: DirectoryJSON = { | ||
| // '/index.cpp': '...', | ||
| // }; | ||
|
|
||
| // virtualFileSystemService.setFileSystem(structure); | ||
| // const isFile = await fileInspector.isFile('/index.cpp'); | ||
| // expect(isFile).toEqual(true); | ||
| // }); |
| @@ -67,6 +68,20 @@ describe('ThinPullRequestsPractice', () => { | |||
| expect(evaluated).toEqual(PracticeEvaluationResult.notPracticing); | |||
| }); | |||
|
|
|||
| it('return unknown if there is no PR', async () => { | |||
| mockCollaborationInspector.listPullRequests = async () => { | |||
| const pr = _.cloneDeep(getPullRequestsResponse()); | |||
|
🎉 This PR is included in version 1.35.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests to increase codecoverage