docs: add list of all practices to README.md #199

adelkahomolova · 2020-01-09T14:59:21Z

Add list of practices in README.md and allow user to use subcommand to list all practices in CLI.

prokopsimek · 2020-01-09T15:02:36Z

DX Scanner Report

https://github.com/DXHeroes/dx-scanner

⚠️ Improvements with medium impact

Break down large pull requests into smaller ones

Large pull request are hard to code review and it reduces the probability of finding bugs. Split your PRs into logical units. Do not have PR with more than 1000 changes. https://medium.com/@hugooodias/the-anatomy-of-a-perfect-pull-request-567382bb6067

Solve Issues Continuously

Do not have an open Issues more than 60 days. Solve Issues continuously. https://hackernoon.com/45-github-issues-dos-and-donts-dfec9ab4b612

Update Dependencies of Minor and Patch Level

Keep the dependencies updated to eliminate security concerns and compatibility issues. Use, for example, npm-check-updates. https://github.com/tjunnone/npm-check-updates

Name	New	Current
@types/eslint	6.1.7	6.1.3
@types/js-yaml	3.12.2	3.12.1
axios	0.19.2	0.19.1
codecov	3.6.2	3.6.1
rimraf	3.0.1	3.0.0
@octokit/rest	16.39.0	16.37.0
simple-git	1.131.0	1.130.0
@types/node	13.5.0	12.12.25
@typescript-eslint/eslint-plugin	2.18.0	2.16.0
@typescript-eslint/parser	2.18.0	2.16.0

Impact changed from high to medium.

🔔 Improvements with minor impact

Write Commit Messages by Convention

https://www.conventionalcommits.org/

Commit Message	Problems
Add fixFlag test	subject may not be empty; type may not be empty
Fix fixPattern regex	subject may not be empty; type may not be empty
Add options to readme	subject may not be empty; type may not be empty
Add fixPattern flag	subject may not be empty; type may not be empty

Update Dependencies of Major Level

Keep the dependencies updated to have all possible features. Use, for example, npm-check-updates. https://github.com/tjunnone/npm-check-updates

Name	New	Current
@semantic-release/changelog	5.0.0	3.0.6
@semantic-release/git	9.0.0	8.0.0
@types/jest	25.1.0	24.9.0
@types/node	13.5.0	12.12.25
@types/semver	7.1.0	6.2.0
semantic-release	17.0.0	16.0.2

Use a JS Logging Library

Use a logging library to avoid errors and even cyber attacks. The most widely used logging library in the JavaScript community is Winston. https://www.npmjs.com/package/winston/

Implementation is not adoption.
We can help you with both. :-)
dxheroes.io

Found a bug? Please report.

…feature/list-practices # Conflicts: # src/index.ts

codecov-io · 2020-01-19T18:34:55Z

Codecov Report

❗ No coverage uploaded for pull request base (master@19e8bd1). Click here to learn what that means.
The diff coverage is 84%.

@@            Coverage Diff            @@
##             master     #199   +/-   ##
=========================================
  Coverage          ?   87.15%           
=========================================
  Files             ?      165           
  Lines             ?     3604           
  Branches          ?      574           
=========================================
  Hits              ?     3141           
  Misses            ?      463           
  Partials          ?        0

Impacted Files	Coverage Δ
src/services/git/IVCSService.ts	`100% <ø> (ø)`
src/inspectors/CollaborationInspector.ts	`100% <ø> (ø)`
src/inspectors/IIssueTrackingInspector.ts	`100% <ø> (ø)`
...s/LanguageIndependent/TimeToSolveIssuesPractice.ts	`100% <100%> (ø)`
...factories/responses/bitbucket/prResponseFactory.ts	`100% <100%> (ø)`
src/scanner/ScannerUtils.ts	`100% <100%> (ø)`
src/test/helpers/bitbucketNock.ts	`100% <100%> (ø)`
src/inspectors/IssueTrackingInspector.ts	`100% <100%> (ø)`
src/services/git/GitHubService.ts	`84.66% <100%> (ø)`
...ractices/JavaScript/ESLintWithoutErrorsPractice.ts	`75.6% <100%> (ø)`
... and 4 more

…feature/list-practices

src/commands/practices.ts

src/commands/run.ts

src/scanner/Scanner.ts

src/scanner/ArgumentsProvider.ts

src/scanner/Scanner.ts

src/commands/practices.ts

- small cleanup BREAKING CHANGE: now exists commands such as init, practices and run

# Conflicts: # README.md # src/index.ts

# [2.0.0-pre-list-practices.1](v1.38.0...v2.0.0-pre-list-practices.1) (2020-01-28) ### Bug Fixes * allow fail and recursive to be optional ([457eb72](457eb72)) * inform user if the config file already exists ([569725a](569725a)) * parse flags with init subcommand ([3ede8e0](3ede8e0)) * remove comments a comment ideas ([e604238](e604238)) * remove unnecessary code ([bb88dd4](bb88dd4)) * remove unused commented code and import reflect-metadata ([5ad591a](5ad591a)) * remove unused flag, aliases and set new examples ([cccdf57](cccdf57)) * rename method ([d8a88cf](d8a88cf)) * rename subcommand ([e939b9e](e939b9e)) * revert change ([b4b6497](b4b6497)) * set arguments back to be required ([dc8edd6](dc8edd6)) * typo ([19e8bd1](19e8bd1)) ### Features * **core:** CLI changed to multi-command ([cbf03b0](cbf03b0)) * add two subcommands ([9661d6b](9661d6b)) * convert init flag to subcommand ([9594d3a](9594d3a)) * implement method to get practices ([871f7f2](871f7f2)) * list practices in a table ([9d8a8f6](9d8a8f6)) * wip - add subcommand ([6c33fc4](6c33fc4)) ### BREAKING CHANGES * **core:** now exists commands such as init, practices and run

prokopsimek · 2020-01-28T10:08:32Z

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

prokopsimek · 2020-01-28T13:51:42Z

🎉 This PR is included in version 2.0.0-pre-lp.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

prokopsimek · 2020-01-28T14:05:18Z

🎉 This PR is included in version 2.0.0-pre-lp-clean2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

prokopsimek · 2020-01-28T15:18:15Z

🎉 This PR is included in version 2.0.0-pre-list-practices-works-for-ts-and-js.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

This reverts commit 7195dd4, reversing changes made to 07eb9ea. # Conflicts: # CHANGELOG.md # package.json

adelkahomolova added 2 commits January 7, 2020 14:57

docs: add list of all practices to README.md

fa1345a

WIP: implement possibility to get list of practices in CLI

06fedeb

adelkahomolova self-assigned this Jan 9, 2020

adelkahomolova added 3 commits January 9, 2020 16:05

Merge branch 'master' of https://github.com/DXHeroes/dx-scanner into …

673148e

…feature/list-practices # Conflicts: # src/index.ts

fix: remove comments a comment ideas

e604238

Merge branch 'master' of https://github.com/DXHeroes/dx-scanner into …

796e30e

…feature/list-practices # Conflicts: # src/index.ts

adelkahomolova added 11 commits January 20, 2020 09:24

feat: wip - add subcommand

6c33fc4

Merge branch 'master' of https://github.com/DXHeroes/dx-scanner into …

1edb872

…feature/list-practices

fix: allow fail and recursive to be optional

457eb72

fix: revert change

b4b6497

feat: implement method to get practices

871f7f2

feat: add two subcommands

9661d6b

Merge branch 'master' of https://github.com/DXHeroes/dx-scanner into …

4754c45

…feature/list-practices

fix: remove unused commented code and import reflect-metadata

5ad591a

fix: rename subcommand

e939b9e

fix: typo

19e8bd1

Merge branch 'master' of https://github.com/DXHeroes/dx-scanner into …

f44d4bf

…feature/list-practices

prokopsimek requested changes Jan 21, 2020

View reviewed changes

adelkahomolova added 10 commits January 22, 2020 10:17

fix: set arguments back to be required

dc8edd6

fix: remove unnecessary code

bb88dd4

fix: remove unused flag, aliases and set new examples

cccdf57

fix: rename method

d8a88cf

fix: inform user if the config file already exists

569725a

feat: convert init flag to subcommand

9594d3a

fix: parse flags with init subcommand

3ede8e0

refactor: sort practices in a function

b903bb9

test: add test for sortAlphabetically()

1463309

feat: list practices in a table

9d8a8f6

adelkahomolova marked this pull request as ready for review January 22, 2020 14:22

adelkahomolova requested a review from prokopsimek January 22, 2020 14:22

prokopsimek force-pushed the feature/list-practices branch from d10571c to dd50436 Compare January 28, 2020 08:44

prokopsimek added 2 commits January 28, 2020 10:08

feat(core): CLI changed to multi-command

cbf03b0

- small cleanup BREAKING CHANGE: now exists commands such as init, practices and run

Merge branch 'master' into feature/list-practices

d0bfc1c

# Conflicts: # README.md # src/index.ts

prokopsimek force-pushed the feature/list-practices branch from 5ed7a54 to d0bfc1c Compare January 28, 2020 09:16

prokopsimek merged commit 7195dd4 into master Jan 28, 2020

prokopsimek deleted the feature/list-practices branch January 28, 2020 09:53

prokopsimek added the released label Jan 28, 2020

prokopsimek added the released on @feature/lp label Jan 28, 2020

prokopsimek added the released on @feature/lp-clean2 label Jan 28, 2020

prokopsimek added a commit that referenced this pull request Jan 28, 2020

Revert "Merge pull request #199 from DXHeroes/feature/list-practices"

af398b2

This reverts commit 7195dd4, reversing changes made to 07eb9ea. # Conflicts: # CHANGELOG.md # package.json

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: add list of all practices to README.md #199

docs: add list of all practices to README.md #199

adelkahomolova commented Jan 9, 2020

prokopsimek commented Jan 9, 2020 •

edited

Loading

codecov-io commented Jan 19, 2020 •

edited

Loading

prokopsimek commented Jan 28, 2020

prokopsimek commented Jan 28, 2020

prokopsimek commented Jan 28, 2020

prokopsimek commented Jan 28, 2020

docs: add list of all practices to README.md #199

docs: add list of all practices to README.md #199

Conversation

adelkahomolova commented Jan 9, 2020

prokopsimek commented Jan 9, 2020 • edited Loading

DX Scanner Report

https://github.com/DXHeroes/dx-scanner

⚠️ Improvements with medium impact

🔔 Improvements with minor impact

Found a bug? Please report.

codecov-io commented Jan 19, 2020 • edited Loading

Codecov Report

prokopsimek commented Jan 28, 2020

prokopsimek commented Jan 28, 2020

prokopsimek commented Jan 28, 2020

prokopsimek commented Jan 28, 2020

prokopsimek commented Jan 9, 2020 •

edited

Loading

codecov-io commented Jan 19, 2020 •

edited

Loading