Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(semantic-release): configure semantic-release for beta branches #210

Closed
wants to merge 2 commits into from

Conversation

prokopsimek
Copy link
Member

Description

Configure semantic-release to release beta branches named according to PR branch names.

Motivation and Context

To be able to test DX Scanner on feature and hotfix branches.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I haven't repeated the code. (DRY)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@prokopsimek prokopsimek self-assigned this Jan 20, 2020
@prokopsimek
Copy link
Member Author

prokopsimek commented Jan 20, 2020

DX Scanner Report DXScanner.io

https://github.com/DXHeroes/dx-scanner

⚠️ Improvements with medium impact

Solve Issues Continuously

Do not have an open Issues more than 60 days. Solve Issues continuously. https://hackernoon.com/45-github-issues-dos-and-donts-dfec9ab4b612

Update Dependencies of Minor and Patch Level

Keep the dependencies updated to eliminate security concerns and compatibility issues. Use, for example, npm-check-updates. https://github.com/tjunnone/npm-check-updates

Name New Current
@types/node 13.1.8 12.12.25

Impact changed from high to medium.

ESLint Without Errors

Use the ESLint correctly. You have some errors. https://eslint.org/

🔔 Improvements with minor impact

Write Commit Messages by Convention

https://www.conventionalcommits.org/

Commit Message Problems
Test/increase codecoverage (#204) subject may not be empty; type may not be empty
                                                          |                                                                        

Test/increase codecoverage |
docs: Travis badge uses a master branch to show build status | subject must not be sentence-case, start-case, pascal-case, upper-case

Update Dependencies of Major Level

Keep the dependencies updated to have all possible features. Use, for example, npm-check-updates. https://github.com/tjunnone/npm-check-updates

Name New Current
@types/node 13.1.8 12.12.25
Use a JS Logging Library

Use a logging library to avoid errors and even cyber attacks. The most widely used logging library in the JavaScript community is Winston. https://www.npmjs.com/package/winston/

🔥 Evaluation of these practices failed - Break down large pull requests into smaller ones

Implementation is not adoption.
We can help you with both. :-)
dxheroes.io

Found a bug? Please report.

@prokopsimek prokopsimek force-pushed the debug/semantic-beta-releases branch from a529f0f to 12c081a Compare January 20, 2020 10:02
@codecov-io
Copy link

codecov-io commented Jan 20, 2020

Codecov Report

Merging #210 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #210   +/-   ##
=======================================
  Coverage   87.38%   87.38%           
=======================================
  Files         164      164           
  Lines        3559     3559           
  Branches      558      558           
=======================================
  Hits         3110     3110           
  Misses        449      449

@prokopsimek prokopsimek force-pushed the debug/semantic-beta-releases branch from 12c081a to caf721a Compare January 20, 2020 10:26
@prokopsimek prokopsimek force-pushed the debug/semantic-beta-releases branch from caf721a to 934422c Compare January 20, 2020 13:46
@prokopsimek prokopsimek deleted the debug/semantic-beta-releases branch January 21, 2020 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants