-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: java logger used practice #219
Conversation
DX Scanner Reporthttps://github.com/DXHeroes/dx-scanner
|
Name | New | Current |
---|---|---|
@octokit/rest | 16.38.1 | 16.37.0 |
@types/eslint | 6.1.6 | 6.1.3 |
axios | 0.19.2 | 0.19.1 |
@types/jest | 24.9.1 | 24.9.0 |
codecov | 3.6.2 | 3.6.1 |
semantic-release | 16.0.3 | 16.0.2 |
@octokit/rest | 16.38.1 | 16.37.0 |
@types/node | 13.5.0 | 12.12.25 |
@typescript-eslint/eslint-plugin | 2.17.0 | 2.16.0 |
@typescript-eslint/parser | 2.17.0 | 2.16.0 |
Impact changed from high to medium.
🔔 Improvements with minor impact
Write Commit Messages by Convention
https://www.conventionalcommits.org/
Commit Message | Problems |
---|---|
removed non-functional code | subject may not be empty; type may not be empty |
Hotfix/failing thin pull requests practice (#207) | subject may not be empty; type may not be empty |
|
fix: failing thin pull requests practice |
Update Dependencies of Major Level
Keep the dependencies updated to have all possible features. Use, for example, npm-check-updates. https://github.com/tjunnone/npm-check-updates
Name | New | Current |
---|---|---|
@types/node | 13.5.0 | 12.12.25 |
jest | 25.1.0 | 24.9.0 |
ts-jest | 25.0.0 | 24.3.0 |
Use a JS Logging Library
Use a logging library to avoid errors and even cyber attacks. The most widely used logging library in the JavaScript community is Winston. https://www.npmjs.com/package/winston/
Implementation is not adoption.
We can help you with both. :-)
dxheroes.io
Found a bug? Please report.
Codecov Report
@@ Coverage Diff @@
## master #219 +/- ##
==========================================
- Coverage 87.3% 87.28% -0.02%
==========================================
Files 166 167 +1
Lines 3615 3627 +12
Branches 578 580 +2
==========================================
+ Hits 3156 3166 +10
- Misses 459 461 +2
Continue to review full report at Codecov.
|
🎉 This PR is included in version 1.38.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
This PR aims to solve issue #217
Motivation and Context
Types of changes
Checklist: