Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: java practice for detecting test mock frameworks #215

Merged
merged 3 commits into from
Jan 27, 2020

Conversation

ryzzaki
Copy link
Contributor

@ryzzaki ryzzaki commented Jan 22, 2020

Description

This PR aims to solve issue #212

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I haven't repeated the code. (DRY)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@prokopsimek
Copy link
Member

prokopsimek commented Jan 22, 2020

DX Scanner Report DXScanner.io

https://github.com/DXHeroes/dx-scanner

⚠️ Improvements with medium impact

Break down large pull requests into smaller ones

Large pull request are hard to code review and it reduces the probability of finding bugs. Split your PRs into logical units. Do not have PR with more than 1000 changes. https://medium.com/@hugooodias/the-anatomy-of-a-perfect-pull-request-567382bb6067

Solve Issues Continuously

Do not have an open Issues more than 60 days. Solve Issues continuously. https://hackernoon.com/45-github-issues-dos-and-donts-dfec9ab4b612

Update Dependencies of Minor and Patch Level

Keep the dependencies updated to eliminate security concerns and compatibility issues. Use, for example, npm-check-updates. https://github.com/tjunnone/npm-check-updates

Name New Current
@octokit/rest 16.38.1 16.37.0
@types/eslint 6.1.5 6.1.3
axios 0.19.2 0.19.1
@types/node 13.1.8 12.12.25
codecov 3.6.2 3.6.1
semantic-release 16.0.3 16.0.2
@octokit/rest 16.38.1 16.37.0
@typescript-eslint/eslint-plugin 2.17.0 2.16.0
@typescript-eslint/parser 2.17.0 2.16.0

Impact changed from high to medium.

🔔 Improvements with minor impact

Write Commit Messages by Convention

https://www.conventionalcommits.org/

Commit Message Problems
removed non-functional code subject may not be empty; type may not be empty
Hotfix/failing thin pull requests practice (#207) subject may not be empty; type may not be empty
                                               |                                                 

fix: failing thin pull requests practice |

Update Dependencies of Major Level

Keep the dependencies updated to have all possible features. Use, for example, npm-check-updates. https://github.com/tjunnone/npm-check-updates

Name New Current
@types/node 13.1.8 12.12.25
jest 25.1.0 24.9.0
ts-jest 25.0.0 24.3.0
Use a JS Logging Library

Use a logging library to avoid errors and even cyber attacks. The most widely used logging library in the JavaScript community is Winston. https://www.npmjs.com/package/winston/


Implementation is not adoption.
We can help you with both. :-)
dxheroes.io

Found a bug? Please report.

@codecov-io
Copy link

codecov-io commented Jan 23, 2020

Codecov Report

Merging #215 into master will increase coverage by 0.1%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #215     +/-   ##
=========================================
+ Coverage   87.23%   87.34%   +0.1%     
=========================================
  Files         166      167      +1     
  Lines        3612     3627     +15     
  Branches      576      580      +4     
=========================================
+ Hits         3151     3168     +17     
+ Misses        461      459      -2
Impacted Files Coverage Δ
src/detectors/Java/JavaComponentDetector.ts 100% <ø> (ø) ⬆️
src/practices/Java/JavaPackageManagementUsed.ts 100% <100%> (ø)
...ices/JavaScript/JsPackageManagementUsedPractice.ts 100% <100%> (ø) ⬆️
src/practices/index.ts 100% <100%> (ø) ⬆️
src/scanner/Scanner.ts 31.75% <0%> (+0.67%) ⬆️
src/inspectors/FileInspector.ts 83.58% <0%> (+1.49%) ⬆️

@ryzzaki ryzzaki marked this pull request as ready for review January 23, 2020 14:25
@prokopsimek prokopsimek merged commit 126e1d1 into master Jan 27, 2020
@prokopsimek prokopsimek deleted the practice/java_mock_framework branch January 27, 2020 15:46
@prokopsimek
Copy link
Member

🎉 This PR is included in version 1.38.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants