Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: java practice for naming conventions #225

Merged
merged 11 commits into from
Feb 5, 2020

Conversation

ryzzaki
Copy link
Contributor

@ryzzaki ryzzaki commented Jan 27, 2020

Description

This PR is aimed to solve issue #224

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I haven't repeated the code. (DRY)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@prokopsimek
Copy link
Member

prokopsimek commented Jan 27, 2020

DX Scanner Report DXScanner.io

https://github.com/DXHeroes/dx-scanner

⚠️ Improvements with medium impact

Break down large pull requests into smaller ones

Large pull request are hard to code review and it reduces the probability of finding bugs. Split your PRs into logical units. Do not have PR with more than 1000 changes. https://medium.com/@hugooodias/the-anatomy-of-a-perfect-pull-request-567382bb6067

Solve Issues Continuously

Do not have an open Issues more than 60 days. Solve Issues continuously. https://hackernoon.com/45-github-issues-dos-and-donts-dfec9ab4b612

Update Dependencies of Minor and Patch Level

Keep the dependencies updated to eliminate security concerns and compatibility issues. Use, for example, npm-check-updates. https://github.com/tjunnone/npm-check-updates

Name New Current
@types/eslint 6.1.8 6.1.7
commander ^4.1.1 ^4.1.0
@types/node 13.7.0 12.12.26
@typescript-eslint/eslint-plugin 2.19.0 2.18.0
@typescript-eslint/parser 2.19.0 2.18.0
ts-jest 25.2.0 25.1.0

Impact changed from high to medium.

ESLint Without Errors

Use the ESLint correctly. You have some errors. https://eslint.org/

🔔 Improvements with minor impact

Write Commit Messages by Convention

https://www.conventionalcommits.org/

Commit Message Problems
fix(init): Win architecture & tests (#238) subject must not be sentence-case, start-case, pascal-case, upper-case
                                        |                                                                        

fix(init): Win architecture & tests |
fix(init): Win architecture & tests | subject must not be sentence-case, start-case, pascal-case, upper-case

Update Dependencies of Major Level

Keep the dependencies updated to have all possible features. Use, for example, npm-check-updates. https://github.com/tjunnone/npm-check-updates

Name New Current
bitbucket 2.0.1 1.17.1
@semantic-release/changelog 5.0.0 3.0.6
@semantic-release/git 9.0.0 8.0.0
@types/node 13.7.0 12.12.26
semantic-release 17.0.2 16.0.4
Use a JS Logging Library

Use a logging library to avoid errors and even cyber attacks. The most widely used logging library in the JavaScript community is Winston. https://www.npmjs.com/package/winston/


Implementation is not adoption.
We can help you with both. :-)
dxheroes.io

Found a bug? Please report.

@prokopsimek
Copy link
Member

@all-contributors please add @ryzzaki for code

@allcontributors
Copy link
Contributor

@prokopsimek

I've put up a pull request to add @ryzzaki! 🎉

@ryzzaki ryzzaki self-assigned this Jan 28, 2020
@codecov-io
Copy link

codecov-io commented Jan 28, 2020

Codecov Report

Merging #225 into master will increase coverage by 3.38%.
The diff coverage is 93.42%.

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
+ Coverage   87.02%   90.41%   +3.38%     
==========================================
  Files         167      170       +3     
  Lines        3631     3830     +199     
  Branches      580      639      +59     
==========================================
+ Hits         3160     3463     +303     
+ Misses        471      367     -104
Impacted Files Coverage Δ
...rc/practices/Java/JavaNamingConventionsPractice.ts 100% <100%> (+80%) ⬆️
...ractices/Java/JavaPackageManagementUsedPractice.ts 100% <100%> (ø)
src/practices/index.ts 100% <100%> (ø) ⬆️
src/practices/Java/JavaLoggerUsedPractice.ts 100% <100%> (ø)
src/detectors/Java/JavaLanguageDetector.ts 100% <100%> (ø) ⬆️
src/scanner/Scanner.ts 87.8% <100%> (+56.04%) ⬆️
...practices/Java/JavaMockingFrameworkUsedPractice.ts 100% <100%> (ø)
src/test/factories/ArgumentsProviderFactory.ts 100% <100%> (ø) ⬆️
...ractices/Java/JavaGitignoreCorrectlySetPractice.ts 100% <100%> (ø) ⬆️
...practices/Java/JavaTestingFrameworkUsedPractice.ts 100% <100%> (ø)
... and 17 more

@ryzzaki ryzzaki marked this pull request as ready for review January 28, 2020 12:19
Copy link
Member

@prokopsimek prokopsimek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryzzaki The PR is ok but please, change the names of tests as @adelkahomolova commented.

@prokopsimek prokopsimek merged commit d3d7fe0 into master Feb 5, 2020
@prokopsimek prokopsimek deleted the practice/java_naming_convention branch February 5, 2020 07:56
@prokopsimek
Copy link
Member

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants