-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: java practice for naming conventions #225
Conversation
DX Scanner Reporthttps://github.com/DXHeroes/dx-scanner
|
Name | New | Current |
---|---|---|
@types/eslint | 6.1.8 | 6.1.7 |
commander | ^4.1.1 | ^4.1.0 |
@types/node | 13.7.0 | 12.12.26 |
@typescript-eslint/eslint-plugin | 2.19.0 | 2.18.0 |
@typescript-eslint/parser | 2.19.0 | 2.18.0 |
ts-jest | 25.2.0 | 25.1.0 |
Impact changed from high to medium.
ESLint Without Errors
Use the ESLint correctly. You have some errors. https://eslint.org/
🔔 Improvements with minor impact
Write Commit Messages by Convention
https://www.conventionalcommits.org/
Commit Message | Problems |
---|---|
fix(init): Win architecture & tests (#238) | subject must not be sentence-case, start-case, pascal-case, upper-case |
|
fix(init): Win architecture & tests |
fix(init): Win architecture & tests | subject must not be sentence-case, start-case, pascal-case, upper-case
Update Dependencies of Major Level
Keep the dependencies updated to have all possible features. Use, for example, npm-check-updates. https://github.com/tjunnone/npm-check-updates
Name | New | Current |
---|---|---|
bitbucket | 2.0.1 | 1.17.1 |
@semantic-release/changelog | 5.0.0 | 3.0.6 |
@semantic-release/git | 9.0.0 | 8.0.0 |
@types/node | 13.7.0 | 12.12.26 |
semantic-release | 17.0.2 | 16.0.4 |
Use a JS Logging Library
Use a logging library to avoid errors and even cyber attacks. The most widely used logging library in the JavaScript community is Winston. https://www.npmjs.com/package/winston/
Implementation is not adoption.
We can help you with both. :-)
dxheroes.io
Found a bug? Please report.
@all-contributors please add @ryzzaki for code |
I've put up a pull request to add @ryzzaki! 🎉 |
Codecov Report
@@ Coverage Diff @@
## master #225 +/- ##
==========================================
+ Coverage 87.02% 90.41% +3.38%
==========================================
Files 167 170 +3
Lines 3631 3830 +199
Branches 580 639 +59
==========================================
+ Hits 3160 3463 +303
+ Misses 471 367 -104
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ryzzaki The PR is ok but please, change the names of tests as @adelkahomolova commented.
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
This PR is aimed to solve issue #224
Motivation and Context
Types of changes
Checklist: