Hotfix/failing thin pull requests practice (#207)

fix: failing thin pull requests practice
DXHeroes · Jan 21, 2020 · 7813c93 · 7813c93
2 parents a25b5b9 + 153f153
commit 7813c93
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 10 deletions.
diff --git a/src/inspectors/CollaborationInspector.spec.ts b/src/inspectors/CollaborationInspector.spec.ts
@@ -34,7 +34,7 @@ describe('Collaboration Inspector', () => {
   it('returns paginated pull requests', async () => {
     new GitHubNock('1', 'octocat', 1296269, 'Hello-World').getPulls({
       pulls: [
-        { number: 1347, state: 'open', title: 'new-feature', body: 'Please pull these awesome changes', head: 'new-topic', base: 'master' },
+        { number: 1, state: 'open', title: 'new-feature', body: 'Please pull these awesome changes', head: 'new-topic', base: 'master' },
       ],
     });
 

diff --git a/src/practices/LanguageIndependent/ThinPullRequestsPractice.ts b/src/practices/LanguageIndependent/ThinPullRequestsPractice.ts
@@ -14,13 +14,13 @@ import { Paginated } from '../../inspectors';
   name: 'Break down large pull requests into smaller ones',
   impact: PracticeImpact.medium,
   suggestion:
-    'Large pull request are hard to code review and it reduces the probability of finding bugs. Split your PRs into logical units. Do not have PR with more than 500 changes.',
+    'Large pull request are hard to code review and it reduces the probability of finding bugs. Split your PRs into logical units. Do not have PR with more than 1000 changes.',
   reportOnlyOnce: true,
   url: 'https://medium.com/@hugooodias/the-anatomy-of-a-perfect-pull-request-567382bb6067',
   dependsOn: { practicing: ['LanguageIndependent.DoesPullRequests'] },
 })
 export class ThinPullRequestsPractice implements IPractice {
-  private readonly measurePullRequestCount = 500; // update suggestion text when changed
+  private readonly measurePullRequestCount = 1000; // update suggestion text when changed
 
   async isApplicable(): Promise<boolean> {
     return true;

diff --git a/src/services/git/GitHubService.spec.ts b/src/services/git/GitHubService.spec.ts
@@ -53,7 +53,7 @@ describe('GitHub Service', () => {
       new GitHubNock('1', 'octocat', 1296269, 'Hello-World').getPulls({
         pulls: [
           {
-            number: 1347,
+            number: 1,
             state: 'open',
             title: 'new-feature',
             body: 'Please pull these awesome changes',
@@ -69,7 +69,7 @@ describe('GitHub Service', () => {
 
     it('returns pulls in own interface with diffStat', async () => {
       const params = {
-        number: 1347,
+        number: 1,
         state: 'open',
         title: 'new-feature',
         body: 'Please pull these awesome changes',
@@ -108,7 +108,7 @@ describe('GitHub Service', () => {
       new GitHubNock('1', 'octocat', 1296269, 'Hello-World').getPulls({
         pulls: [
           {
-            number: 1347,
+            number: 1,
             state: 'open',
             title: 'new-feature',
             body: 'Please pull these awesome changes',

diff --git a/src/services/git/GitHubService.ts b/src/services/git/GitHubService.ts
@@ -93,7 +93,7 @@ export class GitHubService implements IVCSService {
           closedAt: val.closed_at,
           mergedAt: val.merged_at,
           state: val.state,
-          id: val.id,
+          id: val.number, // Lists details of a pull request by providing its number. - https://developer.github.com/v3/pulls/
           base: {
             repo: {
               url: val.base.repo.url,
@@ -105,7 +105,7 @@ export class GitHubService implements IVCSService {
         };
         // Get number of changes, additions and deletions in PullRequest if the withDiffStat is true
         if (options?.withDiffStat) {
-          const lines = await this.getPullsDiffStat(owner, repo, val.id);
+          const lines = await this.getPullsDiffStat(owner, repo, val.number);
           return { ...pullRequest, lines };
         }
         return pullRequest;
@@ -136,7 +136,7 @@ export class GitHubService implements IVCSService {
       closedAt: response.data.closed_at,
       mergedAt: response.data.merged_at,
       state: response.data.state,
-      id: response.data.id,
+      id: response.data.number, // Lists details of a pull request by providing its number. - https://developer.github.com/v3/pulls/
       base: {
         repo: {
           url: response.data.base.repo.url,

diff --git a/src/services/git/__MOCKS__/gitHubServiceMockFolder/getPullsServiceResponse.mock.ts b/src/services/git/__MOCKS__/gitHubServiceMockFolder/getPullsServiceResponse.mock.ts
@@ -25,7 +25,7 @@ export const getPullsServiceResponse: Paginated<PullRequest> = {
       mergedAt: '2011-01-26T19:01:12Z',
       state: 'open',
       updatedAt: '2011-01-26T19:01:12Z',
-      url: 'https://api.github.com/repos/octocat/Hello-World/pulls/1347',
+      url: 'https://api.github.com/repos/octocat/Hello-World/pulls/1',
       user: { id: '1', login: 'octocat', url: 'https://api.github.com/users/octocat' },
     },
   ],