Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

combine modules and themes as one extension in DB #3644

Closed
craigh opened this issue Jul 14, 2017 · 1 comment
Closed

combine modules and themes as one extension in DB #3644

craigh opened this issue Jul 14, 2017 · 1 comment
Labels
Milestone

Comments

@craigh
Copy link
Member

craigh commented Jul 14, 2017

Modules and themes should be considered one 'extension' in the DB. This means sharing most type of entity properties including capabilities, etc.

event names should be updated here and replaced EXTENSIONS_INSTALL etc. and act upon themes as well.

  • \Zikula\ThemeModule\EventListener\ExtensionInstallationListener::getSubscribedEvents
@craigh craigh added the Feature label Jul 14, 2017
@craigh craigh added this to the 3.0 milestone Jul 14, 2017
craigh added a commit that referenced this issue Jul 14, 2017
craigh added a commit that referenced this issue Jul 14, 2017
craigh added a commit that referenced this issue Jul 14, 2017
craigh added a commit that referenced this issue Jul 14, 2017
* #3644

* #3644

* Use SchemaValidationHelper to accomplish all validation for an extension

* #3646

* convert todo to simple note

* remove todo

* #3647

* remove deprecated plugin type

* remove todo

* remove todo

* refs #3530

* #3648

* #3648

* don't restrict filenames in doc controller

* #3454

* rem todo

* inject translator

* restrict doc controller arg @Guite

* #3649

* send specific message about group membership

* send specific message about group membership

* ci

* translate validation error

* remove todo

* #3650

* #3651

* #3644

* #3652, #2915

* #2915

* #2842

* rem todo

* #2842

* #3653

* revert mistaken change
@Guite Guite modified the milestones: 3.0.0, 4.0.0 Nov 2, 2018
@Guite Guite modified the milestones: 4.0.0, 3.0.0 Mar 15, 2019
@Guite Guite mentioned this issue Nov 26, 2019
4 tasks
This was referenced Jan 11, 2020
Guite added a commit that referenced this issue Jan 21, 2020
* simplifying translations

* cs

* cs

* updated composer.lock

* updated composer.lock

* integration for edit in place and web ui

* cs

* removed reference to obsolete property

* use release of js-translation-bundle again

* wording

* separated some reasonable domains

* added doc about domain usage

* removed old domain concept

* cs

* minor fix

* vendor update

* use constants instead of strings

* use constants instead of strings

* use new directory for reading translation files

* support reading different translation catalogue formats

* minor doc typos

* use locales instead of languages to support regions, too

* stop using two variables in parallel

* extend locale api to support lists without and with regions

* centralised locale-related configs, reflect auto-discovery of new locales in config

* cs

* update locale configuration if needed when using translation UI

* sync config when calling settings

* cosmetics

* regenerated Routes

* updated button class

* automatic handling of translation configs for extensions, refs #3644

* cs

* added more variants to docs

* cs

* show also how to extract for multiple locales

* include all themes

* avoid exceptions when intl extension is not available

* bugfixes

* removed workaround; minor performance improvements

* several bugfixes and cleanups

* cs

* adjusted test

* removed experimental state

* adjusted test

* more understandable description

* use bionic in Travis, install intl extension

* further adjustments to Travis config

* further adjustments to Travis config

* further adjustments to Travis config

* further adjustments to Travis config

* further adjustments to Travis config

* fixed tests

* regenerated Routes

* fixed extraction issue

* updated menu addition

* updated path

* regenerated Routes

* removed translator usages from knp menus

* updated constant

* removed unused import

* regenerated

* regression

* vendor update

* cs

* prepare first custom visitors

* added custom extractors for form alerts and input groups

* cs

* minor doc update

* docs update

* added example for multiple help messages

* added KnpMenu extractors

* cs

* minor cleanup

* updated route extraction
craigh added a commit that referenced this issue Feb 3, 2020
Refactor modules and themes into one concept -> extensions.
Refs #3644
@craigh
Copy link
Member Author

craigh commented Feb 3, 2020

fixed by #4103

@craigh craigh closed this as completed Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants