Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

namespace extension javascript translation #3650

Closed
craigh opened this issue Jul 14, 2017 · 1 comment
Closed

namespace extension javascript translation #3650

craigh opened this issue Jul 14, 2017 · 1 comment
Assignees
@Guite
Labels
Feature Language/Translation
Milestone
3.0.0

Comments

@craigh
Copy link
Member

craigh commented Jul 14, 2017 •
edited by Guite
Loading

currently all translations are stored in a zikula_javascript namespace. If possible, change this so that extensions use their own namespace.

  • \Zikula\Bundle\CoreBundle\Translation\...\ZikulaJsFileExtractor::JAVASCRIPT_DOMAIN
  • \Zikula\Bundle\CoreBundle\Translation\...\ZikulaJsFileExtractor::visitFile
  • \Zikula\ThemeModule\EventListener\DefaultPageAssetSetterListener::addJsTranslation

Also consider option of dumping translations to /web
@craigh craigh added the Feature label Jul 14, 2017
@craigh craigh added this to the 2.1.0 milestone Jul 14, 2017
craigh added a commit that referenced this issue Jul 14, 2017
@craigh
#3650
90fb831
craigh added a commit that referenced this issue Jul 14, 2017
@craigh
Todos (#3654)
81c8070 
* #3644

* #3644

* Use SchemaValidationHelper to accomplish all validation for an extension

* #3646

* convert todo to simple note

* remove todo

* #3647

* remove deprecated plugin type

* remove todo

* remove todo

* refs #3530

* #3648

* #3648

* don't restrict filenames in doc controller

* #3454

* rem todo

* inject translator

* restrict doc controller arg @Guite

* #3649

* send specific message about group membership

* send specific message about group membership

* ci

* translate validation error

* remove todo

* #3650

* #3651

* #3644

* #3652, #2915

* #2915

* #2842

* rem todo

* #2842

* #3653

* revert mistaken change
@Guite Guite modified the milestones: 2.1.0, 3.0.0, 4.0.0 Nov 2, 2018
@craigh craigh mentioned this issue Jan 3, 2020
Closed
@Guite Guite mentioned this issue Jan 10, 2020
Closed
@Guite Guite modified the milestones: 4.0.0, 3.0.0 Jan 10, 2020
@Guite Guite self-assigned this Jan 24, 2020
@Guite
Copy link
Member

Guite commented Jan 31, 2020

We are not using the <extensionname>_javascript convention anymore. Instead, JavaScript can use arbitrary domains and even the same one as PHP.

Slightly refs 2d01c89

Closing.

@Guite Guite closed this as completed Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Guite Guite

Labels
Feature Language/Translation
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@Guite @craigh