Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PrinterTheme decoding links twice #3653

Closed
craigh opened this issue Jul 14, 2017 · 1 comment
Closed

PrinterTheme decoding links twice #3653

craigh opened this issue Jul 14, 2017 · 1 comment
Labels
Bug
Milestone
3.0.0

Comments

@craigh
Copy link
Member

craigh commented Jul 14, 2017

in \Zikula\PrinterTheme\ZikulaPrinterTheme::createFootnotes there is

$this->links[] = html_entity_decode(html_entity_decode($matches[1]));

it is unknown why this is decoding twice
@craigh craigh added the Bug label Jul 14, 2017
@craigh craigh added this to the 2.1.0 milestone Jul 14, 2017
craigh added a commit that referenced this issue Jul 14, 2017
@craigh
#3653
94d54c1
craigh added a commit that referenced this issue Jul 14, 2017
@craigh
Todos (#3654)
81c8070 
* #3644

* #3644

* Use SchemaValidationHelper to accomplish all validation for an extension

* #3646

* convert todo to simple note

* remove todo

* #3647

* remove deprecated plugin type

* remove todo

* remove todo

* refs #3530

* #3648

* #3648

* don't restrict filenames in doc controller

* #3454

* rem todo

* inject translator

* restrict doc controller arg @Guite

* #3649

* send specific message about group membership

* send specific message about group membership

* ci

* translate validation error

* remove todo

* #3650

* #3651

* #3644

* #3652, #2915

* #2915

* #2842

* rem todo

* #2842

* #3653

* revert mistaken change
@Guite Guite modified the milestones: 2.1.0, 3.0.0 Nov 2, 2018
Guite added a commit that referenced this issue Mar 19, 2019
@Guite
removed ancient workaround in printer theme, refs #3653
132bf3e
@Guite
Copy link
Member

Guite commented Mar 19, 2019

Just removed this workaround which even existed already when the core code has been transferred to GitHub.

@Guite Guite closed this as completed Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@Guite @craigh