Installer fix #3991
Merged
Installer fix #3991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e.g. run the console)
|
@Guite - your feedback is welcome. I will continue to work on this branch as I find time. You're assistance with the ImagineBundle would be very helpful. Of course, there are multiple things wrong here, this is only a work in progress. |
Guite
reviewed
Nov 25, 2019
Guite
reviewed
Nov 25, 2019
Guite
reviewed
Nov 25, 2019
Guite
reviewed
Nov 25, 2019
src/system/ThemeModule/EventListener/DefaultPageAssetSetterListener.php
Outdated
Show resolved
Hide resolved
|
I like the approach: getting the composer instance from the event seems a nice to migrate our custom actions. |
This reverts commit 37ed8c7.
… - this requires change in the generator
not sure why that ticket was closed without removing this lib. But throwing errors now, so removing
I'm not sure these will work properly in locations other than my own. This may need further work and gain some flexibility in the future - possibly using `router.request_context.base_url` setting
|
|
|
regarding 838fa1c for reference: paths can be tricky. especially because different production environments can be in myriad sub-directories. |
[ci skip] [skip ci]
Apply fixes from StyleCI
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
trying to get project to build - e.g. composer will full work and run all scripts
also make sure that console runs properly
Todos