Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme type in templates (and not only) #2359

Closed
nmpetkov opened this issue Mar 18, 2015 · 8 comments
Closed

Theme type in templates (and not only) #2359

nmpetkov opened this issue Mar 18, 2015 · 8 comments

Comments

@nmpetkov
Copy link
Contributor

I am working on responsive theme, and need to get specific information about the theme - if the theme is responsive or not. Currently I use a ugly solution, checking if displayname contains string 'bootstrap'.

After exploring the code from Zikula 1.2 to Zikula 1.4, I found, that now two fields (columns) in theme table are not in use:
type
xhtml
(historically they was in use, but not after Zikula 1.2)

I propose one of them to be used for that purpose. It seems type is more suitable, as xhtml can be used in future to specify which HTML standards are followed in the theme (for example HTML5 can be one option).

The problem is addressed for both Zikula 1.3 and 1.4 branches.

@craigh craigh added this to the 2.0.0 milestone Mar 19, 2015
@craigh
Copy link
Member

craigh commented Mar 19, 2015

I don't see a systematic solution for this until 2.0.0

perhaps something like modules have a 'capabilities' key in the meta array.

@Guite Guite modified the milestones: 2.0.0-beta1, 2.0.0 Nov 5, 2016
@craigh craigh added the Feature label Apr 2, 2017
@craigh craigh modified the milestones: 2.1.0, 2.0.0 Apr 2, 2017
@craigh craigh removed the Discussion label Apr 2, 2017
@Guite
Copy link
Member

Guite commented Jun 20, 2017

Somewhen modules and themes will be merged. Then themes could reuse the capabilities field....

@Guite Guite modified the milestones: 2.1.0, 3.0.0, 4.0.0 Nov 2, 2018
@Guite
Copy link
Member

Guite commented Nov 2, 2018

modules and themes will be merged

refs #3644

@Guite
Copy link
Member

Guite commented Jan 31, 2020

The xhtml property has been removed.

Somewhen modules and themes will be merged. Then themes could reuse the capabilities field....

Moving this issue to 3.0.0 because it refs #3644.

@Guite Guite modified the milestones: 4.0.0, 3.0.0 Jan 31, 2020
@Guite

This comment has been minimized.

@Guite
Copy link
Member

Guite commented Feb 5, 2020

wondering whether this has become a "won't fix"

  1. @nmpetkov asked for 1.3 and 1.4
  2. all themes are responsive today, aren't they?
  3. I don't see the use case (anymore)

@nmpetkov do you still have an opinion about this?

@nmpetkov
Copy link
Contributor Author

nmpetkov commented Feb 5, 2020

As 1.3 is not supported anymore, the issue is better to close.

@nmpetkov nmpetkov closed this as completed Feb 5, 2020
@Guite Guite modified the milestones: 3.0.0, Discarded Tickets Feb 5, 2020
@Guite
Copy link
Member

Guite commented Feb 5, 2020

Thanks for your feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants