Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge bugfixes in 25.6 release branch #23921

Draft
wants to merge 21 commits into
base: release/25.6
Choose a base branch
from
Draft

Merge bugfixes in 25.6 release branch #23921

wants to merge 21 commits into from

Conversation

kean
Copy link
Contributor

@kean kean commented Dec 23, 2024 •
edited
Loading

This PR contains about 15 bug fixes that were created in trunk targeting 25.6.

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

wpmobilebot and others added 20 commits December 16, 2024 16:32
@wpmobilebot
Merge release/25.6 into trunk (#23899)
67a3534 
* Bump version number

* Update draft release notes for 25.6.

* Update draft release notes for 25.6.

* Release Notes: add new section for next version (25.7)

* Update strings for localization
@pinarol @kean
Bump Gravatar to 3.1.0 (#23868)
bb5191d 
* Bump Gravatar SDK to 3.1.0

* Set Gravatar to "3.1.0-rc.1"

* Update Gravatar to 3.1.0

* Add release notes

* Update release notes

---------

Co-authored-by: kean <grebenyuk.alexander@gmail.com>
@kean
Refactor: Rework PostCompactCell (#23893)
79cbec0 
* Rework PostCompactCell

* Remove obsolete tests
@dependabot
Bump fastlane from 2.225.0 to 2.226.0 (#23903)
738620c 
Bumps [fastlane](https://github.com/fastlane/fastlane) from 2.225.0 to 2.226.0.
- [Release notes](https://github.com/fastlane/fastlane/releases)
- [Changelog](https://github.com/fastlane/fastlane/blob/master/CHANGELOG.latest.md)
- [Commits](fastlane/fastlane@fastlane/2.225.0...fastlane/2.226.0)

---
updated-dependencies:
- dependency-name: fastlane
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump fastlane-plugin-wpmreleasetoolkit from 12.3.4 to 12.4.0 (#23901)
3cff8fc 
Bumps [fastlane-plugin-wpmreleasetoolkit](https://github.com/wordpress-mobile/release-toolkit) from 12.3.4 to 12.4.0.
- [Release notes](https://github.com/wordpress-mobile/release-toolkit/releases)
- [Changelog](https://github.com/wordpress-mobile/release-toolkit/blob/trunk/CHANGELOG.md)
- [Commits](wordpress-mobile/release-toolkit@12.3.4...12.4.0)

---
updated-dependencies:
- dependency-name: fastlane-plugin-wpmreleasetoolkit
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@kean
Reader: Enhance cover image (#23897)
f035b18 
* Replace DimensionFetcher usage

* Remove ImageLoader usage from ReaderDetailFeaturedImageView

* Remove ImageLoader from StatsLatestPostSummaryInsightsCell

* Remove ImageDimensionsFetcher usage

* Remove unused useCompatibilityMode

* Move reading preferences to the more menu

* Add a bit more spacing for posts in Reader

* Refine AsyncImageView API

* Fix dark/light transition on scroll

* Update release notes
@dependabot
Bump rubocop from 1.69.1 to 1.69.2 (#23902)
4dc1ad5 
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.69.1 to 1.69.2.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.69.1...v1.69.2)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@kean
Refactor: Add WordPressMedia (#23890)
3937a09 
* Add WordPressMedia

* Add Swift 6 support

* Fix build
@kean
Remove TipKit FF (#23906)
5912208
@kean
Show Notifications Bell in more places in Reader (#23904)
0e5b61f
@kean
Move FaviconService (#23905)
2f334e2
@kean
Fix crash when pushing the same VC twice in Reader
171c27c
@kean
Add release note
b00da1e
@spencertransier
Use the xcode-16.2-macos-14.7.1-v1 CI image (#23894)
ba8b320
@jkmassel @kean @crazytonyli
Add Image Playground Support (#23688)
046a6c6 
* Add ImagePlayground support in Gutenberg

* Integrate ImagePlayground in GutenberG

* Move ImagePlayground code to MediaPickerMenu

* Integrate SiteIcon picker

* Integrate in PostSettingsViewController

* Integrate in Media Picker

* Update WordPress/Classes/ViewRelated/Media/MediaPicker/MediaPickerMenu+ImagePlayground.swift

Co-authored-by: Tony Li <tony.li@automattic.com>

* Update release notes

---------

Co-authored-by: kean <grebenyuk.alexander@gmail.com>
Co-authored-by: Alex Grebenyuk <alex.grebenyuk@automattic.com>
Co-authored-by: Tony Li <tony.li@automattic.com>
@kean
Fix crash when pushing the same VC twice in Reader (#23907)
fbf817b
@kean
Five improvements for ReaderDetailHeaderView (#23909)
de3bf0b 
* Fix button like animation

* Hide toolbar on scroll

* Use CachedAsyncImage

* Fix subscribe button position and header layout issues

* Rename ReaderDetailHeaderView

* Update release notes
@kean
Fix order in Stats / Subsribers / Emails (#23913)
ecb0a5a 
* Fix subscriber summary not reloading

* Fix order in Stats / Subsribers / Emails

* Update release notes
@kean
Fix off-by-one error in post likes (#23912)
d634ed4 
* Fix formatting in getLikesFor

* Refactor ReaderDetailLikesView

* Simplify ReaderDetailLikesView further

* Update release notes

* Fix compilation in tests
@kean
Fix crash in Reader stream empty state views (#23908)
cc26fec 
* Fix crash in Reader empty state views and fix some layout issues

* Fix frame conversion
@dangermattic
Copy link
Collaborator

3 Warnings
⚠️ Modules/Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages as appropriate to your project setup (e.g. in Xcode or by running swift package resolve).
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
2 Messages
📖 This PR contains changes to RELEASE-NOTES.txt.
Note that these changes won't affect the final version of the release notes as this version is in code freeze.
Please, get in touch with a release manager if you want to update the final release notes.
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23921-24b36d3
Version25.6
Bundle IDorg.wordpress.alpha
Commit24b36d3
App Center BuildWPiOS - One-Offs #11224
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23921-24b36d3
Version25.6
Bundle IDcom.jetpack.alpha
Commit24b36d3
App Center Buildjetpack-installable-builds #10262
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kean @dangermattic @wpmobilebot @pinarol @spencertransier @jkmassel