-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reader: Enhance cover image #23897
Merged
Merged
Reader: Enhance cover image #23897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
kean
changed the title
Refactor: Remove ImageLoader from a few more places
Reader: Enhance cover image
Dec 14, 2024
14 tasks
kean
commented
Dec 16, 2024
@@ -5,23 +5,59 @@ import Gifu | |||
/// (see ``AnimatedImage``). | |||
@MainActor | |||
final class AsyncImageView: UIView { | |||
let imageView = GIFImageView() | |||
|
|||
private let imageView = GIFImageView() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I enhanced the API so that the implementation details (GIFImageView
) don't leak and AsyncImageView
has full control over the image. The image
property will now also correctly support AnimagedImage
, both setter and getter.
crazytonyli
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the cover image behavior a little bit. Changes:
ImageLoader
,CachedAnimatedImageView
, andImageDimensionsFetcher
usagesAsyncImageView
APISimulator.Screen.Recording.-.iPhone.16.Pro.-.2024-12-14.at.18.14.17.mp4
To test:
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txt
if necessary.Testing checklist: