Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post hero image in landscape mode #17098

Closed
ravishanker opened this issue Aug 30, 2021 · 2 comments
Closed

Post hero image in landscape mode #17098

ravishanker opened this issue Aug 30, 2021 · 2 comments

Comments

@ravishanker
Copy link
Contributor

Expected behavior

Hero image on post screen in landscape mode needs to be shown full height and transparent behind navigation options as in portrait mode

Actual behavior

Hero image on post screen in landscape mode is not shown full height and not transparent behind navigation options

Steps to reproduce the behavior

  • Go to reader
  • Open a post with a header image in portrait mode see that it is shown in full and transparent behind navigation
  • Rotate, notice that the image is not full length and navigation bar in black on top of the image
Tested on [device], iOS [version], WPiOS [version]

iPhone Xs, iOS 14.6, WPiOS 18.1

@kean
Copy link
Contributor

kean commented Dec 18, 2024

It looks like it was fixed in #23897. I can't repro it:

Screenshot 2024-12-18 at 1 21 40 PM

The size is now the same across all images and no longer depends on image dimensions.

@kean kean closed this as completed Dec 18, 2024
@kean kean added the [Pri] Low label Dec 18, 2024
@dangermattic
Copy link
Collaborator

Thanks for reporting! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants