Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when pushing the same VC twice in Reader #23907

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Conversation

kean
Copy link
Contributor

@kean kean commented Dec 18, 2024

Fixes https://a8c.sentry.io/issues/3140539221.

It is as a workaround as I don't know how to reproduce it. Hopefully, it will become clearer once we get a full stack trace from wpAssertionFailure.

To test:

I verified that the fix works by calling safePushViewController twice.

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added this to the 25.6 ❄️ milestone Dec 18, 2024
@kean kean added the Reader label Dec 18, 2024
@kean kean requested a review from crazytonyli December 18, 2024 16:31
@dangermattic
Copy link
Collaborator

dangermattic commented Dec 18, 2024

1 Warning
⚠️ This PR is assigned to the milestone 25.6 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@kean kean force-pushed the fix/crash-push-vc-reader branch from 05feb4a to b00da1e Compare December 18, 2024 16:32
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23907-b00da1e
Version25.6
Bundle IDorg.wordpress.alpha
Commitb00da1e
App Center BuildWPiOS - One-Offs #11205
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23907-b00da1e
Version25.6
Bundle IDcom.jetpack.alpha
Commitb00da1e
App Center Buildjetpack-installable-builds #10243
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean enabled auto-merge December 19, 2024 15:05
@kean kean added this pull request to the merge queue Dec 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 19, 2024
@kean kean merged commit fbf817b into trunk Dec 19, 2024
25 checks passed
@kean kean deleted the fix/crash-push-vc-reader branch December 19, 2024 16:26
Copy link

sentry-io bot commented Dec 23, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ NSInvalidArgumentException: <UINavigationController: 0x1083cde00> is pushing the same view controller instance (<_TtGC7SwiftU... ReaderPresenter.popMainNavigationController View Issue
  • ‼️ NSInvalidArgumentException: <UINavigationController: 0x118031800> is pushing the same view controller instance (<WordPress.Re... ReaderPresenter.popMainNavigationController View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants