Fix off-by-one error in post likes

[kean]

Fixes #23911.

To address it, I decided to simplify it with the following changes:

• Remove the animations as they were adding little value as you don't interact with this view or even see it when adding likes
• Use unidirectional data flow by observing a post object, which is the source of truth for number of likes. Remove the two properties that were storing the number of likes resulting in duplicated state.

In addition, I made a couple of other formatting and other improvements, including rewriting some of the code to use pure functions.

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-12-19.at.13.30.40.mp4

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-12-19.at.13.30.10.mp4

To test:

Regression Notes

1. Potential unintended areas of impact

2. What I did to test those areas of impact (or what existing automated tests I relied on)

3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

• WordPress.com sites and self-hosted Jetpack sites.
• Portrait and landscape orientations.
• Light and dark modes.
• Fonts: Larger, smaller and bold text.
• High contrast.
• VoiceOver.
• Languages with large words or with letters/accents not frequently used in English.
• Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• iPhone and iPad.
• Multi-tasking: Split view and Slide over. (iPad)

[dangermattic]

	1 Warning
⚠️	This PR is assigned to the milestone 25.6 ❄️. The due date for this milestone has already passed. Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

[kean]

displaysSelfAvatar was the root cause, as the selfAvatarImageView hidden value was being updated after showing the a number of likes. So, there was an easier fix, but I opted to refactor it to make it completely reliable as there could be other issues.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr23912-706e6e8
	Version	25.6
	Bundle ID	org.wordpress.alpha
	Commit	706e6e8
	App Center Build	WPiOS - One-Offs #11213

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr23912-706e6e8
	Version	25.6
	Bundle ID	com.jetpack.alpha
	Commit	706e6e8
	App Center Build	jetpack-installable-builds #10251

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.