Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Notifications bell in more places in Reader #23904

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

kean
Copy link
Contributor

@kean kean commented Dec 18, 2024

  • Show Notifications bell in Site and Tags screens – basically every screen in the main menu except for search now
  • Replace the "Share" Gridicons – we are no longer using these, and it didn't look good next to the bell
Screenshot 2024-12-17 at 8 44 33 PM Screenshot 2024-12-17 at 8 44 31 PM

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added the Reader label Dec 18, 2024
@kean kean added this to the 25.6 ❄️ milestone Dec 18, 2024
@kean kean requested a review from crazytonyli December 18, 2024 01:47
@dangermattic
Copy link
Collaborator

dangermattic commented Dec 18, 2024

1 Warning
⚠️ This PR is assigned to the milestone 25.6 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

let shareButton = UIBarButtonItem(customView: button)
shareButton.accessibilityLabel = NSLocalizedString("Share", comment: "Spoken accessibility label")
navigationItem.rightBarButtonItem = shareButton
func addRightBarButtonItem(_ item: UIBarButtonItem, after afterTag: NavigationItemTag? = nil) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took inspiration from the API that you use to manage command menu on macOS.

@kean kean force-pushed the task/show-notifications-bell-in-more-places branch from 947120f to 4b43281 Compare December 18, 2024 01:48
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23904-4b43281
Version25.6
Bundle IDorg.wordpress.alpha
Commit4b43281
App Center BuildWPiOS - One-Offs #11201
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23904-4b43281
Version25.6
Bundle IDcom.jetpack.alpha
Commit4b43281
App Center Buildjetpack-installable-builds #10239
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean enabled auto-merge December 18, 2024 02:01
@kean kean added this pull request to the merge queue Dec 18, 2024
Merged via the queue into trunk with commit 0e5b61f Dec 18, 2024
25 checks passed
@kean kean deleted the task/show-notifications-bell-in-more-places branch December 18, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants