This repository has been archived by the owner on Jun 2, 2022. It is now read-only.
Next release #301
Closed
Next release #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for basestore ready! 🔨 Explore the source changes: 9b222b5 🔍 Inspect the deploy log: https://app.netlify.com/sites/basestore/deploys/62013db31127ff000893e22e 😎 Browse the preview: https://deploy-preview-301--basestore.netlify.app/bundle-stats |
Gatsby Cloud Build Reportbasestore 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 2m PerformanceLighthouse report
|
Gatsby Cloud Build Reportbasestore 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 2m PerformanceLighthouse report
|
Preview is readyThis pull request generated a Preview👀 Preview: https://preview-301--base.preview.vtex.app |
* Creates styled IconButton * Uses IconButton over Button on Navbar * Uses IconButton on CartSide bar * Uses IconButton on Filter * Renames props to otherProps * Fixes icon size and alignment * Updates icon sizes * Updates header paddings * Removes icon-button class and renames color * Uses IconButton over Button on CartToggle * Triggers CI with an empty commit * Triggers CI with an empty commit * Triggers CI with an empty commit Co-authored-by: Filipe W. Lima <filipe.lima@vtex.com.br>
## What's the purpose of this pull request? Fix a [SonarQube warning](https://github.com/vtex-sites/base.store/runs/5025104180#:~:text=15M/61M%0AINFO%3A%20%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D-,ANNOTATIONS,-Check%20warning%20on) in a piece of the code by following its suggestion of removing a temporary variable. ## How to test it? The last commit should not have SonarQube trigger the warning anymore. Before|After -|- |
* Removes unnecessary padding from breadcrumb
* Fixes select click behavior
* Improves Button Secondary states
* Simplifies disabled buttons styling
* Unifies cursor on Buttons and LinkButtons
* Fixes Accordion click area and cursor
* Attempts to fix menu buttons on mobile
* Improves navbar button position
* Attempts to unify focus on all interactive elements
* Changes theme-color from safari
* Unifies focus
* Fixes LinkButton's disabled state
* Fixes typo
* Updates disabled button token to a more semantical one
Co-authored-by: Fanny Chien <fannychienn@gmail.com>
* Changes focus-ring to focus-ring-visible when possible
* Improves FocusEvent on LinkButton
Co-Authored-By: Eduardo Formiga <eduardo.formiga@gmail.com>
* Updates SkuSelector's focus
* Fixes merge bugs
* Change use of && as safe-guard to 'if'
* Aligns Filters title
* Adds { after 'if' condition
* Rerun tests
* Trigger CI with an empty commit
Co-authored-by: Fanny Chien <fannychienn@gmail.com>
Co-authored-by: Eduardo Formiga <eduardo.formiga@gmail.com>
Co-authored-by: Heitor Carvalho <heitor.carvalho@vtex.com.br>
Co-authored-by: Lucas Feijó <lucas.portela@vtex.com.br>
* Removes unused title * Extracts css from product-gallery section * Tweaks SROnly component * Adds SROnly h1 title to search page * Fixes typo
* Extract UISelect from Sort to its own component * Rename data-ui-select to data-select * Change attribute className to classes * Remove whitespace * Remove aria-label property from Sort * Make 'id' a required attribute for Select * Change 'SelectOptions' type to Record * Use className attribute instead of classes Co-authored-by: Fanny Chien <fannychienn@gmail.com>
* Lazy loading layout components * Prevents to load total count (blink behavior) * Lazy loading grid with loading fallback (CLS solved) * Lazy loading below the fold components and Improves CLS * Trigger CI * Fixes plp filter spec Co-authored-by: Arthur Andrade <arthurfelandrade@gmail.com> * Renames loadable import * Tweaks product listing grid height * Fix: Adds slug as prop * Extracts css to corresponding components/pages * Styles search page and prevent CLS * Lazy loading homepage below the fold components * Removes outer unnecessary bracket Co-authored-by: Filipe W. Lima <fwl.ufpe@gmail.com> * Extracts shared styles * Adds info comments regarding Skeletons * Revert "Extracts shared styles" This reverts commit bc93a0a. * Creates ProductListing section * Aims Search page use Product Listing component * Aims PLP to use ProductListing section * Adds Lazy loading components section to README.md * Update README.md Co-authored-by: Fanny Chien <fannychienn@gmail.com> * Update README.md Co-authored-by: Fanny Chien <fannychienn@gmail.com> Co-authored-by: Arthur Andrade <arthurfelandrade@gmail.com> Co-authored-by: Filipe W. Lima <fwl.ufpe@gmail.com> Co-authored-by: Fanny Chien <fannychienn@gmail.com>
filipewl
approved these changes
Feb 7, 2022
|
done at #307 |
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
Collect changes for the next release to the main branch.
References