This repository has been archived by the owner on Jun 2, 2022. It is now read-only.
[FSSS-178] Adds Changelog file #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 1, 2022 11:04
|
✔️ Deploy Preview for basestore ready! 🔨 Explore the source changes: 79ecc9b 🔍 Inspect the deploy log: https://app.netlify.com/sites/basestore/deploys/61fadb89a45d0e0007d59c00 😎 Browse the preview: https://deploy-preview-296--basestore.netlify.app |
danzanzini
changed the title
Preview is readyThis pull request generated a Preview👀 Preview: https://preview-296--base.preview.vtex.app |
Gatsby Cloud Build Reportbasestore 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 7m PerformanceLighthouse report
|
Gatsby Cloud Build Reportbasestore 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 7m PerformanceLighthouse report
|
filipewl
approved these changes
Feb 2, 2022
There was a problem hiding this comment.
LGTM! Maybe we can consider adopting https://www.conventionalcommits.org/en/v1.0.0/ for automated changelogs later.
Co-authored-by: Filipe W. Lima <fwl.ufpe@gmail.com>
Co-authored-by: George Brindeiro <george.brindeiro@vtex.com.br>
ArthurTriis1
approved these changes
Feb 3, 2022
Closed
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR adds the CHANGELOG file along with its related documentation.
For documentation, I've added a checklist item in the PR template and created a new section on the README called
Contributingthat, for now, only has one item related to the Changelog.How it works?
The CHANGELOG file follows the Keep a Changelog convention. Each PR should add at least one entry in the
[UNRELEASED]section of the CHANGELOG. When it's time to release all of these entries are moved to a entry related to the version being released and a new cleanUNRELEASEDsection is created to receive entries for new PRs.I've set a
0.1.0version on the CHANGELOG that is the closed beta release. We should create a new Github Release version related to this version when we start using our new Github flowJira link
https://vtex-dev.atlassian.net/browse/FSSS-178