This repository has been archived by the owner on Jun 2, 2022. It is now read-only.
Fix a SonarQube warning #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 1, 2022 15:32
> https://github.com/vtex-sites/base.store/runs/5025104180 > src/components/ui/QuantitySelector/QuantitySelector.tsx#L39 > Immediately return this expression instead of assigning it to the temporary variable "minValue".
Fix a SonarQube warning on CI: > https://github.com/vtex-sites/base.store/runs/5025104180 > > src/components/ui/QuantitySelector/QuantitySelector.tsx#L39 > > Immediately return this expression instead of assigning it to the temporary variable "minValue".
filipewl
requested review from
hellofanny,
danzanzini,
israelswf,
eduardoformiga,
lucasfp13,
saranicoly,
heitorado and
ArthurTriis1
|
✔️ Deploy Preview for basestore ready! 🔨 Explore the source changes: c050583 🔍 Inspect the deploy log: https://app.netlify.com/sites/basestore/deploys/61f9bdaf12b1fc0008800655 😎 Browse the preview: https://deploy-preview-297--basestore.netlify.app |
Preview is readyThis pull request generated a Preview👀 Preview: https://preview-297--base.preview.vtex.app |
Gatsby Cloud Build Reportbasestore 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 5m PerformanceLighthouse report
|
Gatsby Cloud Build Reportbasestore 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 5m PerformanceLighthouse report
|
hellofanny
approved these changes
Feb 1, 2022
ArthurTriis1
approved these changes
Feb 2, 2022
lucasfp13
approved these changes
Feb 2, 2022
Closed
danzanzini
pushed a commit
that referenced
this pull request
Feb 7, 2022
## What's the purpose of this pull request? Fix a [SonarQube warning](https://github.com/vtex-sites/base.store/runs/5025104180#:~:text=15M/61M%0AINFO%3A%20%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D-,ANNOTATIONS,-Check%20warning%20on) in a piece of the code by following its suggestion of removing a temporary variable. ## How to test it? The last commit should not have SonarQube trigger the warning anymore. Before|After -|- |
|
danzanzini
pushed a commit
that referenced
this pull request
Feb 7, 2022
## What's the purpose of this pull request? Fix a [SonarQube warning](https://github.com/vtex-sites/base.store/runs/5025104180#:~:text=15M/61M%0AINFO%3A%20%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D%2D-,ANNOTATIONS,-Check%20warning%20on) in a piece of the code by following its suggestion of removing a temporary variable. ## How to test it? The last commit should not have SonarQube trigger the warning anymore. Before|After -|- |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
Fix a SonarQube warning in a piece of the code by following its suggestion of removing a temporary variable.
How to test it?
The last commit should not have SonarQube trigger the warning anymore.