This repository has been archived by the owner on Jun 2, 2022. It is now read-only.
[FSSS-170] Chore: tweaks search page #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for basestore ready! 🔨 Explore the source changes: 5aaef94 🔍 Inspect the deploy log: https://app.netlify.com/sites/basestore/deploys/61f86c8a20dacf00086a413a 😎 Browse the preview: https://deploy-preview-293--basestore.netlify.app |
Preview is readyThis pull request generated a Preview👀 Preview: https://preview-293--base.preview.vtex.app |
Gatsby Cloud Build Reportbasestore 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 3m PerformanceLighthouse report
|
Gatsby Cloud Build Reportbasestore 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 3m PerformanceLighthouse report
|
eduardoformiga
added
depends on
filipewl
approved these changes
Feb 1, 2022
hellofanny
reviewed
Feb 3, 2022
| } | ||
|
|
||
| function SROnly({ text }: Props) { | ||
| return <span data-store-sr-only>{text}</span> | ||
| function SROnly({ text, as }: Props) { |
There was a problem hiding this comment.
In the future we can rename it to a more generic meaning to cover this case (when we need to hide information but not necessary related to screen reader only) 👍
Closed
danzanzini
pushed a commit
that referenced
this pull request
Feb 7, 2022
* Removes unused title * Extracts css from product-gallery section * Tweaks SROnly component * Adds SROnly h1 title to search page * Fixes typo
danzanzini
pushed a commit
that referenced
this pull request
Feb 7, 2022
* Removes unused title * Extracts css from product-gallery section * Tweaks SROnly component * Adds SROnly h1 title to search page * Fixes typo
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
Makes the Search page looks like the PLP so far.
Question: The search page is without any
<h1>tag, should we add it someplace?We decided to keep the
<h1>, but use theSROnly(Screen Reader Only) component.How to test it?
https://preview-293--base.preview.vtex.app/s/?q=shirt&sort=score_desc&page=0