This repository has been archived by the owner on Jun 2, 2022. It is now read-only.
[FSSS-172] Fix/Adjust inappropriate rerenders #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArthurTriis1
force-pushed
the
feat/revisit-rerender
branch
2 times, most recently
from
368ea18 to
9388674
Compare
Preview is readyThis pull request generated a Preview👀 Preview: https://preview-304--base.preview.vtex.app |
ArthurTriis1
changed the title
ArthurTriis1
changed the title
ArthurTriis1
changed the title
danzanzini
approved these changes
Feb 4, 2022
|
VERYY NICEE! 🥳 🥳 Well done!! 🚀 |
|
I also didn't know about that option for the React extension! Today I Learned. |
ArthurTriis1
force-pushed
the
feat/revisit-rerender
branch
from
9388674 to
c58d1b2
Compare
eduardoformiga
approved these changes
Feb 4, 2022
There was a problem hiding this comment.
👏 👏 👏 Heyyy, Amazing changes!
Very nice extractions into new hooks, good use of destructuring, etc.
The code looks more legible and better now! 🤩
I wonder if should we memo small components since maybe keeping the react algorithm rerender can be better for performance in this case. It's more recommendable memo medium to large components.
ref: https://dmitripavlutin.com/use-react-memo-wisely/#2-when-to-use-reactmemo
Signed-off-by: Arthur Andrade <arthurfelandrade@gmail.com>
Signed-off-by: Arthur Andrade <arthurfelandrade@gmail.com>
ArthurTriis1
force-pushed
the
feat/revisit-rerender
branch
from
c58d1b2 to
4f3e1c6
Compare
danzanzini
pushed a commit
that referenced
this pull request
Feb 7, 2022
danzanzini
pushed a commit
that referenced
this pull request
Feb 7, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR fixes some inappropriate rerenders with memo function and removing peer dependencies from hooks. To observe this rerenders I used the React Developer Tools with the option "Highlight updates when components render" checked.