-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong Popup direction on ComboBox #11894
Comments
I tried to reproduce the problem with demo.vaadin.com/sampler by reducing the Window size so that ComboBox popup does not fit below, and it worked correctly by opening it on top of field. So I cannot reproduce this. |
Ok, May be I need to investigate this further but I can reproducte it and went back to the version 8.9.3 where it works fine for me. On the versions 8.10.0 and 8.9.4 the ComboBox always opens below, with 8.9.3 it opens on top. I check if i can find out more about this behaviour. |
I can reproducte it when I put the ComboBox in a HorizontalLayout. Then the Popup always opens blow the ComboBox instead of above. With HorizontalLayout (Popup opens blow which is wrong) Code:
Without HorizontalLayout: (Looks correct) Code:
|
setPopupPosition(left, top); needs to be called in order to top position to be set Fixes #11894
* Adding missing setPopupPosition(left, top); setPopupPosition(left, top); needs to be called in order to top position to be set Fixes #11894
* Adding missing setPopupPosition(left, top); setPopupPosition(left, top); needs to be called in order to top position to be set Fixes #11894
* Removing code causing the trouble (#11898) * Removing code causing the trouble Removing code that was apparently not needed in previous fix and caused regression Fixes: #11895 * Added feature to test UI * Added test case * Adding missing import * Fixing test UI * Enable DateField * Rewrote debouncing of onResize (#11899) * Rewrote debouncing of onResize Fixes #11892 * Fixing typo in variable name * Adding missing setPopupPosition(left, top); (#11902) * Adding missing setPopupPosition(left, top); setPopupPosition(left, top); needs to be called in order to top position to be set Fixes #11894 Co-authored-by: Tatu Lund <tatu@vaadin.com>
- Updated a comment and renamed a private method for better clarity. - Blocked unnecessary position updates. - Added a test for vaadin#11866 / vaadin#11894.
- Updated a comment and renamed a private method for better clarity. - Blocked unnecessary position updates. - Added a test for vaadin#11866 / vaadin#11894.
The popup of a Combobox always open below even if there is actually no space. The Popup shown then is too small and not sowing all items as there is just not enough space (See attachment). This occurs with the Vaadin Versions 8.10.0 and 8.9.4
The text was updated successfully, but these errors were encountered: