-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grid renderes with gap between rows #11892
Comments
* Rewrote debouncing of onResize Fixes #11892 * Fixing typo in variable name
* Rewrote debouncing of onResize Fixes #11892 * Fixing typo in variable name
* Removing code causing the trouble (#11898) * Removing code causing the trouble Removing code that was apparently not needed in previous fix and caused regression Fixes: #11895 * Added feature to test UI * Added test case * Adding missing import * Fixing test UI * Enable DateField * Rewrote debouncing of onResize (#11899) * Rewrote debouncing of onResize Fixes #11892 * Fixing typo in variable name * Adding missing setPopupPosition(left, top); (#11902) * Adding missing setPopupPosition(left, top); setPopupPosition(left, top); needs to be called in order to top position to be set Fixes #11894 Co-authored-by: Tatu Lund <tatu@vaadin.com>
I have not been able to reproduce the issue after the fix. I tested the Sampler too and tried out Chrome, Firefox, Edge and IE11 and it worked ok with all of them. I have received info from others too that fix has been effective. So my understanding is that with the fix the likelihood of this problem has decreased considerably. However as you have managed to still reproduce the problem it just tells that it is still possible. I think it can be attributed to specific computer performance, mouse device etc. One could experimentally try to optimize the debounce interval, which is now 50ms (see: https://github.com/vaadin/framework/blob/master/client/src/main/java/com/vaadin/client/widgets/Grid.java#L9282 ) I would assume that with a bit longer period the likelihood of occurrence is smaller. But we do not want to have too big value there, since there will be noticeable delay after resize before Grid adjusts itself. So fundamentally it is about finding optimum between these. |
Description of the bug
In certain cases, when resizing the browser window or view container, the vaadin grid renders with gaps between rows:
Inspecting the DOM reveals that there is a mismatch in the row
translate3d
property values:The above grids are created in the following way:
Expected behavior
The grid renders correctly and there are no gaps between the rows.
Actual behavior
The grid renders with gaps between rows (as can be seen in the attached images)
Steps to reproduce
We were able to reproduce this issue using the vaadin 8 sampler project: https://demo.vaadin.com/sampler/#ui/grids-and-trees/grid/features
Misc
The text was updated successfully, but these errors were encountered: