Rewrote debouncing of onResize #11899
Conversation
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @TatuLund)
client/src/main/java/com/vaadin/client/widgets/Grid.java, line 4370 at r1 (raw file):
private boolean resizeRequested = false; private boolean resizeRerfreshScheduled = false;
typo, rename to "resizeRefreshSchaduled"
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @OlliTietavainenVaadin)
client/src/main/java/com/vaadin/client/widgets/Grid.java, line 4370 at r1 (raw file):
Previously, OlliTietavainenVaadin (Olli Tietäväinen) wrote…
typo, rename to "resizeRefreshSchaduled"
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @OlliTietavainenVaadin)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
* Rewrote debouncing of onResize Fixes #11892 * Fixing typo in variable name
* Removing code causing the trouble (#11898) * Removing code causing the trouble Removing code that was apparently not needed in previous fix and caused regression Fixes: #11895 * Added feature to test UI * Added test case * Adding missing import * Fixing test UI * Enable DateField * Rewrote debouncing of onResize (#11899) * Rewrote debouncing of onResize Fixes #11892 * Fixing typo in variable name * Adding missing setPopupPosition(left, top); (#11902) * Adding missing setPopupPosition(left, top); setPopupPosition(left, top); needs to be called in order to top position to be set Fixes #11894 Co-authored-by: Tatu Lund <tatu@vaadin.com>
Fixes #11892
This change is