-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert 'Rewrote debouncing of onResize (#11899)' #12051
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @Ansku)
uitest/src/main/java/com/vaadin/tests/components/grid/GridScrolledResize.java, line 15 at r1 (raw file):
public class GridScrolledResize extends AbstractTestUI { Label spaceGrabber;
Not sure if this needs to be an instance variable. If so, please make it private.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Ansku)
uitest/src/main/java/com/vaadin/tests/components/grid/GridScrolledResize.java, line 15 at r1 (raw file): Previously, edler-san wrote…
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @edler-san)
Fixes #12049
This change is