Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert 'Rewrote debouncing of onResize (#11899)' #12051

Merged
merged 1 commit into from
Jul 9, 2020

Conversation

Ansku
Copy link
Member

@Ansku Ansku commented Jul 8, 2020

Fixes #12049

This change is Reviewable

Copy link
Contributor

@edler-san edler-san left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @Ansku)


uitest/src/main/java/com/vaadin/tests/components/grid/GridScrolledResize.java, line 15 at r1 (raw file):

public class GridScrolledResize extends AbstractTestUI {

    Label spaceGrabber;

Not sure if this needs to be an instance variable. If so, please make it private.

Copy link
Contributor

@edler-san edler-san left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Ansku)

@Ansku
Copy link
Member Author

Ansku commented Jul 9, 2020


uitest/src/main/java/com/vaadin/tests/components/grid/GridScrolledResize.java, line 15 at r1 (raw file):

Previously, edler-san wrote…

Not sure if this needs to be an instance variable. If so, please make it private.

Done.

Copy link
Contributor

@edler-san edler-san left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @edler-san)

@Ansku Ansku merged commit a173480 into vaadin:master Jul 9, 2020
Ansku added a commit that referenced this pull request Jul 14, 2020
@TatuLund TatuLund added this to the 8.11.2 milestone Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grid onResize not updating Horizontal scroll position if hz-scroller not needed
3 participants