Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combobox - wrong popup menu positioning #12029

Closed
AndreevXSoft opened this issue Jun 3, 2020 · 1 comment · Fixed by #12041
Closed

Combobox - wrong popup menu positioning #12029

AndreevXSoft opened this issue Jun 3, 2020 · 1 comment · Fixed by #12041

Comments

@AndreevXSoft
Copy link

Vaadin Framework version 8.11.0 and 8.10.5

While writing in the field and only one item matches, the popup menu is being positioned incorrectly.

combobox_wrong_popup_position

I guess this fix caused this problem: #11894

Version Vaadin 8.9.4 does not have this problem, but in this version when there is not enough space below for the popup menu, it does not show above.
@evanzel
Copy link

evanzel commented Jun 18, 2020

I stumbled upon the same ugliness.
When the popup is positioned above and then you continue with filtering the items and the number of filtered items is less than the pagelength the popup continues to be positioned at the same y position, so we get an empty space.

Ansku added a commit to Ansku/framework that referenced this issue Jun 25, 2020
@Ansku
Update ComboBox popup position comparison to use correct top value.
c2ec658 
Fixes vaadin#12029
@Ansku Ansku mentioned this issue Jun 25, 2020
Merged
OlliTietavainenVaadin pushed a commit that referenced this issue Jun 26, 2020
@Ansku
Update ComboBox popup position comparison to use correct top value. (#…
797b493 
…12041)

Fixes #12029
ZheSun88 pushed a commit that referenced this issue Jul 1, 2020
@Ansku @ZheSun88
Update ComboBox popup position comparison to use correct top value. (#…
70a46a8 
…12041)

Fixes #12029
TatuLund added a commit that referenced this issue Jul 1, 2020
@ZheSun88 @tarekoraby
@Ansku @TatuLund
Cherry pick 8.11.1 (#12046)
89dfd79 
* Fix rendering of TreeGrid's frozen columns after hierarchy-column reset (#12028)

* Add tests

* Fix getVisibleFrozenColumnCount() if SelectionMode is multi

* Update ComboBox popup position comparison to use correct top value. (#12041)

Fixes #12029

* Clear thread local instances on connection lost in push handler (#12042)

Adopted from vaadin/flow#8567

Co-authored-by: Tarek Oraby <42799254+tarekoraby@users.noreply.github.com>
Co-authored-by: Anna Koskinen <Ansku@users.noreply.github.com>
Co-authored-by: Tatu Lund <tatu@vaadin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update ComboBox popup position comparison to use correct top value. Ansku/framework
2 participants
@AndreevXSoft @evanzel