Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further tweaks to ComboBox popup positioning. (#11910) #11921

Merged
merged 1 commit into from
Mar 24, 2020
Merged

Further tweaks to ComboBox popup positioning. (#11910) #11921

merged 1 commit into from
Mar 24, 2020

Conversation

Ansku
Copy link
Member

@Ansku Ansku commented Mar 23, 2020 •
edited by Artur-
Loading

  • Further tweaks to ComboBox popup positioning.

This change is Reviewable

@Ansku
Further tweaks to ComboBox popup positioning. (#11910)
371756e 
* Further tweaks to ComboBox popup positioning.

- Updated a comment and renamed a private method for better clarity.
- Blocked unnecessary position updates.
- Added a test for #11866 / #11894.
@Ansku Ansku added this to the 8.10.3 milestone Mar 23, 2020
TatuLund
TatuLund approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@TatuLund TatuLund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Ansku Ansku merged commit e7abf49 into 8.10 Mar 24, 2020
@Ansku Ansku deleted the issue11866release branch March 24, 2020 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TatuLund TatuLund TatuLund approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.10.3
Development

Successfully merging this pull request may close these issues.
2 participants
@Ansku @TatuLund