Avoid cableEngine cleanup when the gateway pod is restarted #2499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the current code, it was seen that when the submariner-gateway pod gets restarted, there is a brief datapath disruption until the new pod comes online. The cleanup code in submariner-gateway pod is not required as its handled by the route-agent code when there is any transition in the Gateway nodes. Partially fixes: submariner-io#2498 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
|
🤖 Created branch: z_pr2499/sridhargaddam/issue-2498 |
tpantelis
approved these changes
May 26, 2023
|
@tpantelis @skitt @aswinsuryan @yboaron I verified this PR couple of times in a KIND deployment and captured my observations in the commit message. I haven't got a chance to verify it on an OCP deployment. Do you think we should validate this once (although the fix looks valid and is reasonable) even with OCP before merging. Any thoughts? |
Given that the change was introduced for OVNK, I think we should verify it on OCP with OVNK before merging. |
|
Ah, I was basing my comment above only on the notification email, which didn’t include the nice table in the description. I see you’ve already tested this with OVNK on kind, so I don’t think testing on OCP is absolutely necessary. |
dfarrell07
approved these changes
May 26, 2023
|
🤖 Closed branches: [z_pr2499/sridhargaddam/issue-2498] |
nyechiel
added
the
backport
This was referenced Jun 2, 2023
Merged
sridhargaddam
added a commit
to sridhargaddam/submariner
that referenced
this pull request
Jun 2, 2023
…2499-origin-release-0.14
skitt
added a commit
to sridhargaddam/submariner
that referenced
this pull request
Jun 2, 2023
…2499-origin-release-0.14
tpantelis
added a commit
to sridhargaddam/submariner
that referenced
this pull request
Jun 2, 2023
…2499-origin-release-0.13
sridhargaddam
added a commit
to sridhargaddam/submariner-website
that referenced
this pull request
Jul 5, 2023
Includes the release notes for the following fixes. * Submariner now uses case-insensitive comparison while parsing CNI names. * subctl gather now collects Metrics proxy pod logs in a Globalnet deployment. * Submariner Gateway pod now skips invoking cableEngine cleanup during termination, as this is handled by the Route agent during gateway migration. * Fixed issue which caused the IPsec pluto process to crash when the remote endpoint was unstable. * Submariner now handles out-of-order remote endpoint notifications properly in Globalnet component. Related to: submariner-io/submariner#2486 Related to: submariner-io/subctl#770 Related to: submariner-io/submariner#2499 Related to: submariner-io/submariner#2517 Related to: submariner-io/submariner#2532 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
sridhargaddam
added a commit
to sridhargaddam/submariner-website
that referenced
this pull request
Jul 6, 2023
Includes the release notes for the following fixes. * Submariner now uses case-insensitive comparison while parsing CNI names. * subctl gather now collects Metrics proxy pod logs in a Globalnet deployment. * Submariner Gateway pod now skips invoking cableEngine cleanup during termination, as this is handled by the Route agent during gateway migration. * Fixed issue which caused the IPsec pluto process to crash when the remote endpoint was unstable. * Submariner now handles out-of-order remote endpoint notifications properly in Globalnet component. Related to: submariner-io/submariner#2486 Related to: submariner-io/subctl#770 Related to: submariner-io/submariner#2499 Related to: submariner-io/submariner#2517 Related to: submariner-io/submariner#2532 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
skitt
pushed a commit
to skitt/submariner-website
that referenced
this pull request
Jul 10, 2023
Includes the release notes for the following fixes. * Submariner now uses case-insensitive comparison while parsing CNI names. * subctl gather now collects Metrics proxy pod logs in a Globalnet deployment. * Submariner Gateway pod now skips invoking cableEngine cleanup during termination, as this is handled by the Route agent during gateway migration. * Fixed issue which caused the IPsec pluto process to crash when the remote endpoint was unstable. * Submariner now handles out-of-order remote endpoint notifications properly in Globalnet component. Related to: submariner-io/submariner#2486 Related to: submariner-io/subctl#770 Related to: submariner-io/submariner#2499 Related to: submariner-io/submariner#2517 Related to: submariner-io/submariner#2532 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
skitt
pushed a commit
to skitt/submariner-website
that referenced
this pull request
Jul 10, 2023
Includes the release notes for the following fixes. * Submariner now uses case-insensitive comparison while parsing CNI names. * subctl gather now collects Metrics proxy pod logs in a Globalnet deployment. * Submariner Gateway pod now skips invoking cableEngine cleanup during termination, as this is handled by the Route agent during gateway migration. * Fixed issue which caused the IPsec pluto process to crash when the remote endpoint was unstable. * Submariner now handles out-of-order remote endpoint notifications properly in Globalnet component. Related to: submariner-io/submariner#2486 Related to: submariner-io/subctl#770 Related to: submariner-io/submariner#2499 Related to: submariner-io/submariner#2517 Related to: submariner-io/submariner#2532 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
skitt
pushed a commit
to submariner-io/submariner-website
that referenced
this pull request
Jul 10, 2023
Includes the release notes for the following fixes. * Submariner now uses case-insensitive comparison while parsing CNI names. * subctl gather now collects Metrics proxy pod logs in a Globalnet deployment. * Submariner Gateway pod now skips invoking cableEngine cleanup during termination, as this is handled by the Route agent during gateway migration. * Fixed issue which caused the IPsec pluto process to crash when the remote endpoint was unstable. * Submariner now handles out-of-order remote endpoint notifications properly in Globalnet component. Related to: submariner-io/submariner#2486 Related to: submariner-io/subctl#770 Related to: submariner-io/submariner#2499 Related to: submariner-io/submariner#2517 Related to: submariner-io/submariner#2532 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
dfarrell07
pushed a commit
to dfarrell07/submariner-website
that referenced
this pull request
Oct 18, 2023
Includes the release notes for the following fixes. * Submariner now uses case-insensitive comparison while parsing CNI names. * subctl gather now collects Metrics proxy pod logs in a Globalnet deployment. * Submariner Gateway pod now skips invoking cableEngine cleanup during termination, as this is handled by the Route agent during gateway migration. * Fixed issue which caused the IPsec pluto process to crash when the remote endpoint was unstable. * Submariner now handles out-of-order remote endpoint notifications properly in Globalnet component. Related to: submariner-io/submariner#2486 Related to: submariner-io/subctl#770 Related to: submariner-io/submariner#2499 Related to: submariner-io/submariner#2517 Related to: submariner-io/submariner#2532 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
dfarrell07
pushed a commit
to dfarrell07/submariner-website
that referenced
this pull request
Oct 18, 2023
Includes the release notes for the following fixes. * Submariner now uses case-insensitive comparison while parsing CNI names. * subctl gather now collects Metrics proxy pod logs in a Globalnet deployment. * Submariner Gateway pod now skips invoking cableEngine cleanup during termination, as this is handled by the Route agent during gateway migration. * Fixed issue which caused the IPsec pluto process to crash when the remote endpoint was unstable. * Submariner now handles out-of-order remote endpoint notifications properly in Globalnet component. Related to: submariner-io/submariner#2486 Related to: submariner-io/subctl#770 Related to: submariner-io/submariner#2499 Related to: submariner-io/submariner#2517 Related to: submariner-io/submariner#2532 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
dfarrell07
pushed a commit
to dfarrell07/submariner-website
that referenced
this pull request
Oct 19, 2023
Includes the release notes for the following fixes. * Submariner now uses case-insensitive comparison while parsing CNI names. * subctl gather now collects Metrics proxy pod logs in a Globalnet deployment. * Submariner Gateway pod now skips invoking cableEngine cleanup during termination, as this is handled by the Route agent during gateway migration. * Fixed issue which caused the IPsec pluto process to crash when the remote endpoint was unstable. * Submariner now handles out-of-order remote endpoint notifications properly in Globalnet component. Related to: submariner-io/submariner#2486 Related to: submariner-io/subctl#770 Related to: submariner-io/submariner#2499 Related to: submariner-io/submariner#2517 Related to: submariner-io/submariner#2532 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
tpantelis
pushed a commit
to submariner-io/submariner-website
that referenced
this pull request
Oct 22, 2023
Includes the release notes for the following fixes. * Submariner now uses case-insensitive comparison while parsing CNI names. * subctl gather now collects Metrics proxy pod logs in a Globalnet deployment. * Submariner Gateway pod now skips invoking cableEngine cleanup during termination, as this is handled by the Route agent during gateway migration. * Fixed issue which caused the IPsec pluto process to crash when the remote endpoint was unstable. * Submariner now handles out-of-order remote endpoint notifications properly in Globalnet component. Related to: submariner-io/submariner#2486 Related to: submariner-io/subctl#770 Related to: submariner-io/submariner#2499 Related to: submariner-io/submariner#2517 Related to: submariner-io/submariner#2532 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
tpantelis
pushed a commit
to tpantelis/submariner-website
that referenced
this pull request
Nov 7, 2023
Includes the release notes for the following fixes. * Submariner now uses case-insensitive comparison while parsing CNI names. * subctl gather now collects Metrics proxy pod logs in a Globalnet deployment. * Submariner Gateway pod now skips invoking cableEngine cleanup during termination, as this is handled by the Route agent during gateway migration. * Fixed issue which caused the IPsec pluto process to crash when the remote endpoint was unstable. * Submariner now handles out-of-order remote endpoint notifications properly in Globalnet component. Related to: submariner-io/submariner#2486 Related to: submariner-io/subctl#770 Related to: submariner-io/submariner#2499 Related to: submariner-io/submariner#2517 Related to: submariner-io/submariner#2532 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current code, it was seen that when the submariner-gateway pod gets restarted, there is a brief datapath disruption until the new pod comes online. The cleanup code in submariner-gateway pod is not required as its handled by the route-agent code when there is any transition in the active Gateway of the cluster.
This PR removes the cleanup code from submariner-gateway pod which fixes the issue with VxLAN Cable Driver, but Libreswan Cable Driver seems to have some other issue[s] which needs to be addressed separately.
Partially fixes: #2498
Signed-off-by: Sridhar Gaddam sgaddam@redhat.com