Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gateway pod restart is causing datapath disruption #2498

Closed
sridhargaddam opened this issue May 26, 2023 · 0 comments · Fixed by #2499
Closed

Gateway pod restart is causing datapath disruption #2498

sridhargaddam opened this issue May 26, 2023 · 0 comments · Fixed by #2499
Assignees
@sridhargaddam
Labels
backport This change requires a backport to eligible release branches bug Something isn't working

Comments

@sridhargaddam
Copy link
Member

What happened:

In the current code, it was seen that when the submariner-gateway pod gets restarted, there is a brief datapath disruption until the new pod comes online. It seems to be introduced as part of the following PR while addressing OVN use-cases.

The cleanup code in submariner-gateway pod is not really required as its handled by the route-agent code when there is any transition in the Gateway nodes.

What you expected to happen:
When the submariner-gateway pod is restarted, ideally it would be good if we can avoid any disruptions to the datapath.

How to reproduce it (as minimally and precisely as possible):

  1. Deploy a KIND cluster.
  2. Deploy two pods one on non-GW nodes of cluster-1 and cluster-2
  3. Ping from pod in cluster1 to the pod in cluster2
  4. While the ping is going on, delete the submariner-gateway pod in cluster2
  5. You will notice a brief interruption in the ping traffic until the submariner-gateway pod comes online.
@sridhargaddam sridhargaddam added the bug Something isn't working label May 26, 2023
@sridhargaddam sridhargaddam self-assigned this May 26, 2023
sridhargaddam added a commit to sridhargaddam/submariner that referenced this issue May 26, 2023
@sridhargaddam
Avoid cableEngine cleanup when the gateway pod is restarted
11c410f 
In the current code, it was seen that when the submariner-gateway
pod gets restarted, there is a brief datapath disruption until the
new pod comes online. The cleanup code in submariner-gateway pod is
not required as its handled by the route-agent code when there is
any transition in the Gateway nodes.

Partially fixes: submariner-io#2498
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
@sridhargaddam sridhargaddam mentioned this issue May 26, 2023
Merged
skitt pushed a commit that referenced this issue May 26, 2023
@sridhargaddam @skitt
Avoid cableEngine cleanup when the gateway pod is restarted
8f50f29 
In the current code, it was seen that when the submariner-gateway
pod gets restarted, there is a brief datapath disruption until the
new pod comes online. The cleanup code in submariner-gateway pod is
not required as its handled by the route-agent code when there is
any transition in the Gateway nodes.

Partially fixes: #2498
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
@nyechiel nyechiel added the backport This change requires a backport to eligible release branches label May 28, 2023
sridhargaddam added a commit to sridhargaddam/submariner that referenced this issue Jun 1, 2023
@sridhargaddam
Avoid cableEngine cleanup when the gateway pod is restarted
ff50689 
In the current code, it was seen that when the submariner-gateway
pod gets restarted, there is a brief datapath disruption until the
new pod comes online. The cleanup code in submariner-gateway pod is
not required as its handled by the route-agent code when there is
any transition in the Gateway nodes.

Partially fixes: submariner-io#2498
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
skitt pushed a commit that referenced this issue Jun 1, 2023
@sridhargaddam @skitt
Avoid cableEngine cleanup when the gateway pod is restarted
2abc46e 
In the current code, it was seen that when the submariner-gateway
pod gets restarted, there is a brief datapath disruption until the
new pod comes online. The cleanup code in submariner-gateway pod is
not required as its handled by the route-agent code when there is
any transition in the Gateway nodes.

Partially fixes: #2498
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
sridhargaddam added a commit to sridhargaddam/submariner that referenced this issue Jun 2, 2023
@sridhargaddam
Avoid cableEngine cleanup when the gateway pod is restarted
969ea83 
In the current code, it was seen that when the submariner-gateway
pod gets restarted, there is a brief datapath disruption until the
new pod comes online. The cleanup code in submariner-gateway pod is
not required as its handled by the route-agent code when there is
any transition in the Gateway nodes.

Partially fixes: submariner-io#2498
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
sridhargaddam added a commit to sridhargaddam/submariner that referenced this issue Jun 2, 2023
@sridhargaddam
Avoid cableEngine cleanup when the gateway pod is restarted
9173e0b 
In the current code, it was seen that when the submariner-gateway
pod gets restarted, there is a brief datapath disruption until the
new pod comes online. The cleanup code in submariner-gateway pod is
not required as its handled by the route-agent code when there is
any transition in the Gateway nodes.

Partially fixes: submariner-io#2498
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
skitt pushed a commit that referenced this issue Jun 2, 2023
@sridhargaddam @skitt
Avoid cableEngine cleanup when the gateway pod is restarted
49baa0c 
In the current code, it was seen that when the submariner-gateway
pod gets restarted, there is a brief datapath disruption until the
new pod comes online. The cleanup code in submariner-gateway pod is
not required as its handled by the route-agent code when there is
any transition in the Gateway nodes.

Partially fixes: #2498
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
skitt pushed a commit that referenced this issue Jun 2, 2023
@sridhargaddam @skitt
Avoid cableEngine cleanup when the gateway pod is restarted
ee108a2 
In the current code, it was seen that when the submariner-gateway
pod gets restarted, there is a brief datapath disruption until the
new pod comes online. The cleanup code in submariner-gateway pod is
not required as its handled by the route-agent code when there is
any transition in the Gateway nodes.

Partially fixes: #2498
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
novad03 pushed a commit to novad03/k8s-submariner that referenced this issue Nov 25, 2023
@sridhargaddam @skitt
Avoid cableEngine cleanup when the gateway pod is restarted
edf7a96 
In the current code, it was seen that when the submariner-gateway
pod gets restarted, there is a brief datapath disruption until the
new pod comes online. The cleanup code in submariner-gateway pod is
not required as its handled by the route-agent code when there is
any transition in the Gateway nodes.

Partially fixes: submariner-io/submariner#2498
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sridhargaddam sridhargaddam

Labels
backport This change requires a backport to eligible release branches bug Something isn't working
Projects
No open projects
Submariner 0.16
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid cableEngine cleanup when the gateway pod is restarted sridhargaddam/submariner
2 participants
@sridhargaddam @nyechiel