Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error while running gather in GN setup #770

Merged
merged 2 commits into from
Jun 6, 2023
Merged

Fix error while running gather in GN setup #770

merged 2 commits into from
Jun 6, 2023

Conversation

sridhargaddam
Copy link
Member

In a GN deployment metrics pod includes two containers. This PR ensures that we pass the container name while collecting the logs to avoid the errors.

Fixes: #769

@sridhargaddam
Fix error while running gather in GN setup
407a36e 
In a GN deployment metrics pod includes two containers.
This PR ensures that we pass the container name while
collecting the logs to avoid the errors.

Fixes: submariner-io#769
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr770/sridhargaddam/issue-769
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@submariner-bot submariner-bot added the ready-to-test When a PR is ready for full E2E testing label Jun 6, 2023
@sridhargaddam sridhargaddam enabled auto-merge (rebase) June 6, 2023 08:51
@sridhargaddam sridhargaddam merged commit 11cc0cf into submariner-io:devel Jun 6, 2023
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr770/sridhargaddam/issue-769]

@skitt skitt added the backport This change requires a backport to eligible release branches label Jun 6, 2023
@sridhargaddam sridhargaddam mentioned this pull request Jun 8, 2023
Merged
@sridhargaddam sridhargaddam mentioned this pull request Jun 8, 2023
Merged
@maayanf24 maayanf24 added the release-note-needed Should be mentioned in the release notes label Jun 13, 2023
sridhargaddam added a commit to sridhargaddam/submariner-website that referenced this pull request Jul 5, 2023
@sridhargaddam
Add release notes for couple of PRs
580edbb 
Includes the release notes for the following fixes.

* Submariner now uses case-insensitive comparison while parsing
  CNI names.
* subctl gather now collects Metrics proxy pod logs in a Globalnet
  deployment.
* Submariner Gateway pod now skips invoking cableEngine cleanup during
  termination, as this is handled by the Route agent during gateway migration.
* Fixed issue which caused the IPsec pluto process to crash when the remote
  endpoint was unstable.
* Submariner now handles out-of-order remote endpoint notifications properly
  in Globalnet component.

Related to: submariner-io/submariner#2486
Related to: submariner-io/subctl#770
Related to: submariner-io/submariner#2499
Related to: submariner-io/submariner#2517
Related to: submariner-io/submariner#2532
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
@sridhargaddam sridhargaddam mentioned this pull request Jul 5, 2023
Merged
sridhargaddam added a commit to sridhargaddam/submariner-website that referenced this pull request Jul 6, 2023
@sridhargaddam
Add release notes for couple of PRs
f6003b8 
Includes the release notes for the following fixes.

* Submariner now uses case-insensitive comparison while parsing
  CNI names.
* subctl gather now collects Metrics proxy pod logs in a Globalnet
  deployment.
* Submariner Gateway pod now skips invoking cableEngine cleanup during
  termination, as this is handled by the Route agent during gateway migration.
* Fixed issue which caused the IPsec pluto process to crash when the remote
  endpoint was unstable.
* Submariner now handles out-of-order remote endpoint notifications properly
  in Globalnet component.

Related to: submariner-io/submariner#2486
Related to: submariner-io/subctl#770
Related to: submariner-io/submariner#2499
Related to: submariner-io/submariner#2517
Related to: submariner-io/submariner#2532
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
skitt pushed a commit to skitt/submariner-website that referenced this pull request Jul 10, 2023
@sridhargaddam @skitt
Add release notes for couple of PRs
50eee0a 
Includes the release notes for the following fixes.

* Submariner now uses case-insensitive comparison while parsing
  CNI names.
* subctl gather now collects Metrics proxy pod logs in a Globalnet
  deployment.
* Submariner Gateway pod now skips invoking cableEngine cleanup during
  termination, as this is handled by the Route agent during gateway migration.
* Fixed issue which caused the IPsec pluto process to crash when the remote
  endpoint was unstable.
* Submariner now handles out-of-order remote endpoint notifications properly
  in Globalnet component.

Related to: submariner-io/submariner#2486
Related to: submariner-io/subctl#770
Related to: submariner-io/submariner#2499
Related to: submariner-io/submariner#2517
Related to: submariner-io/submariner#2532
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
skitt pushed a commit to skitt/submariner-website that referenced this pull request Jul 10, 2023
@sridhargaddam @skitt
Add release notes for couple of PRs
042eebd 
Includes the release notes for the following fixes.

* Submariner now uses case-insensitive comparison while parsing
  CNI names.
* subctl gather now collects Metrics proxy pod logs in a Globalnet
  deployment.
* Submariner Gateway pod now skips invoking cableEngine cleanup during
  termination, as this is handled by the Route agent during gateway migration.
* Fixed issue which caused the IPsec pluto process to crash when the remote
  endpoint was unstable.
* Submariner now handles out-of-order remote endpoint notifications properly
  in Globalnet component.

Related to: submariner-io/submariner#2486
Related to: submariner-io/subctl#770
Related to: submariner-io/submariner#2499
Related to: submariner-io/submariner#2517
Related to: submariner-io/submariner#2532
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
skitt pushed a commit to submariner-io/submariner-website that referenced this pull request Jul 10, 2023
@sridhargaddam @skitt
Add release notes for couple of PRs
c1e368b 
Includes the release notes for the following fixes.

* Submariner now uses case-insensitive comparison while parsing
  CNI names.
* subctl gather now collects Metrics proxy pod logs in a Globalnet
  deployment.
* Submariner Gateway pod now skips invoking cableEngine cleanup during
  termination, as this is handled by the Route agent during gateway migration.
* Fixed issue which caused the IPsec pluto process to crash when the remote
  endpoint was unstable.
* Submariner now handles out-of-order remote endpoint notifications properly
  in Globalnet component.

Related to: submariner-io/submariner#2486
Related to: submariner-io/subctl#770
Related to: submariner-io/submariner#2499
Related to: submariner-io/submariner#2517
Related to: submariner-io/submariner#2532
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
dfarrell07 pushed a commit to dfarrell07/submariner-website that referenced this pull request Oct 18, 2023
@sridhargaddam @dfarrell07
Add release notes for couple of PRs
4dfa042 
Includes the release notes for the following fixes.

* Submariner now uses case-insensitive comparison while parsing
  CNI names.
* subctl gather now collects Metrics proxy pod logs in a Globalnet
  deployment.
* Submariner Gateway pod now skips invoking cableEngine cleanup during
  termination, as this is handled by the Route agent during gateway migration.
* Fixed issue which caused the IPsec pluto process to crash when the remote
  endpoint was unstable.
* Submariner now handles out-of-order remote endpoint notifications properly
  in Globalnet component.

Related to: submariner-io/submariner#2486
Related to: submariner-io/subctl#770
Related to: submariner-io/submariner#2499
Related to: submariner-io/submariner#2517
Related to: submariner-io/submariner#2532
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
dfarrell07 pushed a commit to dfarrell07/submariner-website that referenced this pull request Oct 18, 2023
@sridhargaddam @dfarrell07
Add release notes for couple of PRs
c9d5abe 
Includes the release notes for the following fixes.

* Submariner now uses case-insensitive comparison while parsing
  CNI names.
* subctl gather now collects Metrics proxy pod logs in a Globalnet
  deployment.
* Submariner Gateway pod now skips invoking cableEngine cleanup during
  termination, as this is handled by the Route agent during gateway migration.
* Fixed issue which caused the IPsec pluto process to crash when the remote
  endpoint was unstable.
* Submariner now handles out-of-order remote endpoint notifications properly
  in Globalnet component.

Related to: submariner-io/submariner#2486
Related to: submariner-io/subctl#770
Related to: submariner-io/submariner#2499
Related to: submariner-io/submariner#2517
Related to: submariner-io/submariner#2532
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
dfarrell07 pushed a commit to dfarrell07/submariner-website that referenced this pull request Oct 19, 2023
@sridhargaddam @dfarrell07
Add release notes for couple of PRs
38ecd4e 
Includes the release notes for the following fixes.

* Submariner now uses case-insensitive comparison while parsing
  CNI names.
* subctl gather now collects Metrics proxy pod logs in a Globalnet
  deployment.
* Submariner Gateway pod now skips invoking cableEngine cleanup during
  termination, as this is handled by the Route agent during gateway migration.
* Fixed issue which caused the IPsec pluto process to crash when the remote
  endpoint was unstable.
* Submariner now handles out-of-order remote endpoint notifications properly
  in Globalnet component.

Related to: submariner-io/submariner#2486
Related to: submariner-io/subctl#770
Related to: submariner-io/submariner#2499
Related to: submariner-io/submariner#2517
Related to: submariner-io/submariner#2532
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
tpantelis pushed a commit to submariner-io/submariner-website that referenced this pull request Oct 22, 2023
@sridhargaddam @tpantelis
Add release notes for couple of PRs
d30c328 
Includes the release notes for the following fixes.

* Submariner now uses case-insensitive comparison while parsing
  CNI names.
* subctl gather now collects Metrics proxy pod logs in a Globalnet
  deployment.
* Submariner Gateway pod now skips invoking cableEngine cleanup during
  termination, as this is handled by the Route agent during gateway migration.
* Fixed issue which caused the IPsec pluto process to crash when the remote
  endpoint was unstable.
* Submariner now handles out-of-order remote endpoint notifications properly
  in Globalnet component.

Related to: submariner-io/submariner#2486
Related to: submariner-io/subctl#770
Related to: submariner-io/submariner#2499
Related to: submariner-io/submariner#2517
Related to: submariner-io/submariner#2532
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
tpantelis pushed a commit to tpantelis/submariner-website that referenced this pull request Nov 7, 2023
@sridhargaddam @tpantelis
Add release notes for couple of PRs
a2e069e 
Includes the release notes for the following fixes.

* Submariner now uses case-insensitive comparison while parsing
  CNI names.
* subctl gather now collects Metrics proxy pod logs in a Globalnet
  deployment.
* Submariner Gateway pod now skips invoking cableEngine cleanup during
  termination, as this is handled by the Route agent during gateway migration.
* Fixed issue which caused the IPsec pluto process to crash when the remote
  endpoint was unstable.
* Submariner now handles out-of-order remote endpoint notifications properly
  in Globalnet component.

Related to: submariner-io/submariner#2486
Related to: submariner-io/subctl#770
Related to: submariner-io/submariner#2499
Related to: submariner-io/submariner#2517
Related to: submariner-io/submariner#2532
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skitt skitt skitt approved these changes

@maayanf24 maayanf24 maayanf24 approved these changes

@Jaanki Jaanki Awaiting requested review from Jaanki Jaanki is a code owner

@Oats87 Oats87 Awaiting requested review from Oats87 Oats87 is a code owner

@tpantelis tpantelis Awaiting requested review from tpantelis tpantelis is a code owner

Assignees
No one assigned
Labels
backport This change requires a backport to eligible release branches backport-handled ready-to-test When a PR is ready for full E2E testing release-note-handled release-note-needed Should be mentioned in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error while collecting metrics pod logs in GN deployment
4 participants
@sridhargaddam @submariner-bot @skitt @maayanf24