Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pluto crash when remote endpoint is unstable #2517

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Fix pluto crash when remote endpoint is unstable #2517

merged 1 commit into from
Jun 2, 2023

Conversation

sridhargaddam
Copy link
Member

@sridhargaddam sridhargaddam commented Jun 2, 2023 •
edited
Loading

Currently, submariner-gateway pod while invoking the whack commands does not set any dpdaction flags. So the default dpdaction of disabled was applied. While using this action, when the remote endpoint is not responding within a certain duration, some problematic code path in Libreswan was getting executed and leading to crash. The proper fix would be to use an updated Libreswan, but as a workaround we can explicitly set the dpdaction=hold to avoid hitting the problematic code paths.

Related PR in libreswan:
libreswan/libreswan@c7a6113

Fixes: #2516
Co-authored-by: Yossi Boaron yboaron@redhat.com

@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr2517/sridhargaddam/issue-2516
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@submariner-bot submariner-bot added the ready-to-test When a PR is ready for full E2E testing label Jun 2, 2023
@sridhargaddam
Copy link
Member Author

Looking into the linter errors

@sridhargaddam sridhargaddam enabled auto-merge (rebase) June 2, 2023 08:37
@sridhargaddam @yboaron
Fix pluto crash when remote endpoint is unstable
a22f63a 
Currently, submariner-gateway pod while invoking the whack
commands does not set any dpdaction flags. So the default
dpdaction of disabled was applied. While using this action,
when the remote endpoint is not responding within a certain
duration, some problematic code path in Libreswan was getting
executed and leading to crash. The proper fix would be to use
an updated Libreswan, but as a workaround we can explicitly
set the dpdaction=hold to avoid hitting the problematic code
paths.

Related PR in libreswan:
libreswan/libreswan@c7a6113

Fixes: submariner-io#2516
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Co-authored-by: Yossi Boaron <yboaron@redhat.com>
@sridhargaddam sridhargaddam merged commit 274345f into submariner-io:devel Jun 2, 2023
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr2517/sridhargaddam/issue-2516]

@sridhargaddam sridhargaddam mentioned this pull request Jun 2, 2023
Merged
This was referenced Jun 2, 2023
Merged
Merged
dfarrell07 added a commit to sridhargaddam/submariner that referenced this pull request Jun 2, 2023
@dfarrell07
Merge branch 'release-0.13' into automated-backport-of-submariner-io#…
0714783 
…2517-origin-release-0.13
@dfarrell07 dfarrell07 added the release-note-needed Should be mentioned in the release notes label Jun 5, 2023
sridhargaddam added a commit to sridhargaddam/submariner-website that referenced this pull request Jul 5, 2023
@sridhargaddam
Add release notes for couple of PRs
580edbb 
Includes the release notes for the following fixes.

* Submariner now uses case-insensitive comparison while parsing
  CNI names.
* subctl gather now collects Metrics proxy pod logs in a Globalnet
  deployment.
* Submariner Gateway pod now skips invoking cableEngine cleanup during
  termination, as this is handled by the Route agent during gateway migration.
* Fixed issue which caused the IPsec pluto process to crash when the remote
  endpoint was unstable.
* Submariner now handles out-of-order remote endpoint notifications properly
  in Globalnet component.

Related to: submariner-io/submariner#2486
Related to: submariner-io/subctl#770
Related to: submariner-io/submariner#2499
Related to: submariner-io/submariner#2517
Related to: submariner-io/submariner#2532
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
@sridhargaddam sridhargaddam mentioned this pull request Jul 5, 2023
Merged
sridhargaddam added a commit to sridhargaddam/submariner-website that referenced this pull request Jul 6, 2023
@sridhargaddam
Add release notes for couple of PRs
f6003b8 
Includes the release notes for the following fixes.

* Submariner now uses case-insensitive comparison while parsing
  CNI names.
* subctl gather now collects Metrics proxy pod logs in a Globalnet
  deployment.
* Submariner Gateway pod now skips invoking cableEngine cleanup during
  termination, as this is handled by the Route agent during gateway migration.
* Fixed issue which caused the IPsec pluto process to crash when the remote
  endpoint was unstable.
* Submariner now handles out-of-order remote endpoint notifications properly
  in Globalnet component.

Related to: submariner-io/submariner#2486
Related to: submariner-io/subctl#770
Related to: submariner-io/submariner#2499
Related to: submariner-io/submariner#2517
Related to: submariner-io/submariner#2532
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
skitt pushed a commit to skitt/submariner-website that referenced this pull request Jul 10, 2023
@sridhargaddam @skitt
Add release notes for couple of PRs
50eee0a 
Includes the release notes for the following fixes.

* Submariner now uses case-insensitive comparison while parsing
  CNI names.
* subctl gather now collects Metrics proxy pod logs in a Globalnet
  deployment.
* Submariner Gateway pod now skips invoking cableEngine cleanup during
  termination, as this is handled by the Route agent during gateway migration.
* Fixed issue which caused the IPsec pluto process to crash when the remote
  endpoint was unstable.
* Submariner now handles out-of-order remote endpoint notifications properly
  in Globalnet component.

Related to: submariner-io/submariner#2486
Related to: submariner-io/subctl#770
Related to: submariner-io/submariner#2499
Related to: submariner-io/submariner#2517
Related to: submariner-io/submariner#2532
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
skitt pushed a commit to skitt/submariner-website that referenced this pull request Jul 10, 2023
@sridhargaddam @skitt
Add release notes for couple of PRs
042eebd 
Includes the release notes for the following fixes.

* Submariner now uses case-insensitive comparison while parsing
  CNI names.
* subctl gather now collects Metrics proxy pod logs in a Globalnet
  deployment.
* Submariner Gateway pod now skips invoking cableEngine cleanup during
  termination, as this is handled by the Route agent during gateway migration.
* Fixed issue which caused the IPsec pluto process to crash when the remote
  endpoint was unstable.
* Submariner now handles out-of-order remote endpoint notifications properly
  in Globalnet component.

Related to: submariner-io/submariner#2486
Related to: submariner-io/subctl#770
Related to: submariner-io/submariner#2499
Related to: submariner-io/submariner#2517
Related to: submariner-io/submariner#2532
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
skitt pushed a commit to submariner-io/submariner-website that referenced this pull request Jul 10, 2023
@sridhargaddam @skitt
Add release notes for couple of PRs
c1e368b 
Includes the release notes for the following fixes.

* Submariner now uses case-insensitive comparison while parsing
  CNI names.
* subctl gather now collects Metrics proxy pod logs in a Globalnet
  deployment.
* Submariner Gateway pod now skips invoking cableEngine cleanup during
  termination, as this is handled by the Route agent during gateway migration.
* Fixed issue which caused the IPsec pluto process to crash when the remote
  endpoint was unstable.
* Submariner now handles out-of-order remote endpoint notifications properly
  in Globalnet component.

Related to: submariner-io/submariner#2486
Related to: submariner-io/subctl#770
Related to: submariner-io/submariner#2499
Related to: submariner-io/submariner#2517
Related to: submariner-io/submariner#2532
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
@yboaron yboaron mentioned this pull request Oct 16, 2023
Closed
dfarrell07 pushed a commit to dfarrell07/submariner-website that referenced this pull request Oct 18, 2023
@sridhargaddam @dfarrell07
Add release notes for couple of PRs
4dfa042 
Includes the release notes for the following fixes.

* Submariner now uses case-insensitive comparison while parsing
  CNI names.
* subctl gather now collects Metrics proxy pod logs in a Globalnet
  deployment.
* Submariner Gateway pod now skips invoking cableEngine cleanup during
  termination, as this is handled by the Route agent during gateway migration.
* Fixed issue which caused the IPsec pluto process to crash when the remote
  endpoint was unstable.
* Submariner now handles out-of-order remote endpoint notifications properly
  in Globalnet component.

Related to: submariner-io/submariner#2486
Related to: submariner-io/subctl#770
Related to: submariner-io/submariner#2499
Related to: submariner-io/submariner#2517
Related to: submariner-io/submariner#2532
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
dfarrell07 pushed a commit to dfarrell07/submariner-website that referenced this pull request Oct 18, 2023
@sridhargaddam @dfarrell07
Add release notes for couple of PRs
c9d5abe 
Includes the release notes for the following fixes.

* Submariner now uses case-insensitive comparison while parsing
  CNI names.
* subctl gather now collects Metrics proxy pod logs in a Globalnet
  deployment.
* Submariner Gateway pod now skips invoking cableEngine cleanup during
  termination, as this is handled by the Route agent during gateway migration.
* Fixed issue which caused the IPsec pluto process to crash when the remote
  endpoint was unstable.
* Submariner now handles out-of-order remote endpoint notifications properly
  in Globalnet component.

Related to: submariner-io/submariner#2486
Related to: submariner-io/subctl#770
Related to: submariner-io/submariner#2499
Related to: submariner-io/submariner#2517
Related to: submariner-io/submariner#2532
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
dfarrell07 pushed a commit to dfarrell07/submariner-website that referenced this pull request Oct 19, 2023
@sridhargaddam @dfarrell07
Add release notes for couple of PRs
38ecd4e 
Includes the release notes for the following fixes.

* Submariner now uses case-insensitive comparison while parsing
  CNI names.
* subctl gather now collects Metrics proxy pod logs in a Globalnet
  deployment.
* Submariner Gateway pod now skips invoking cableEngine cleanup during
  termination, as this is handled by the Route agent during gateway migration.
* Fixed issue which caused the IPsec pluto process to crash when the remote
  endpoint was unstable.
* Submariner now handles out-of-order remote endpoint notifications properly
  in Globalnet component.

Related to: submariner-io/submariner#2486
Related to: submariner-io/subctl#770
Related to: submariner-io/submariner#2499
Related to: submariner-io/submariner#2517
Related to: submariner-io/submariner#2532
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
tpantelis pushed a commit to submariner-io/submariner-website that referenced this pull request Oct 22, 2023
@sridhargaddam @tpantelis
Add release notes for couple of PRs
d30c328 
Includes the release notes for the following fixes.

* Submariner now uses case-insensitive comparison while parsing
  CNI names.
* subctl gather now collects Metrics proxy pod logs in a Globalnet
  deployment.
* Submariner Gateway pod now skips invoking cableEngine cleanup during
  termination, as this is handled by the Route agent during gateway migration.
* Fixed issue which caused the IPsec pluto process to crash when the remote
  endpoint was unstable.
* Submariner now handles out-of-order remote endpoint notifications properly
  in Globalnet component.

Related to: submariner-io/submariner#2486
Related to: submariner-io/subctl#770
Related to: submariner-io/submariner#2499
Related to: submariner-io/submariner#2517
Related to: submariner-io/submariner#2532
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
tpantelis pushed a commit to tpantelis/submariner-website that referenced this pull request Nov 7, 2023
@sridhargaddam @tpantelis
Add release notes for couple of PRs
a2e069e 
Includes the release notes for the following fixes.

* Submariner now uses case-insensitive comparison while parsing
  CNI names.
* subctl gather now collects Metrics proxy pod logs in a Globalnet
  deployment.
* Submariner Gateway pod now skips invoking cableEngine cleanup during
  termination, as this is handled by the Route agent during gateway migration.
* Fixed issue which caused the IPsec pluto process to crash when the remote
  endpoint was unstable.
* Submariner now handles out-of-order remote endpoint notifications properly
  in Globalnet component.

Related to: submariner-io/submariner#2486
Related to: submariner-io/subctl#770
Related to: submariner-io/submariner#2499
Related to: submariner-io/submariner#2517
Related to: submariner-io/submariner#2532
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skitt skitt skitt approved these changes

@vthapar vthapar vthapar approved these changes

@tpantelis tpantelis tpantelis approved these changes

@Oats87 Oats87 Awaiting requested review from Oats87 Oats87 is a code owner

Assignees
No one assigned
Labels
backport-handled ready-to-test When a PR is ready for full E2E testing release-note-handled release-note-needed Should be mentioned in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IPsec pluto process crashes when the remote endpoint is unstable
6 participants
@sridhargaddam @submariner-bot @skitt @vthapar @tpantelis @dfarrell07