-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated backport of #2499: Avoid cableEngine cleanup when the gateway pod is restarted #2504
Merged
skitt
merged 1 commit into
submariner-io:release-0.15
from
sridhargaddam:automated-backport-of-#2499-origin-release-0.15
Jun 1, 2023
Merged
Automated backport of #2499: Avoid cableEngine cleanup when the gateway pod is restarted #2504
skitt
merged 1 commit into
submariner-io:release-0.15
from
sridhargaddam:automated-backport-of-#2499-origin-release-0.15
Jun 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the current code, it was seen that when the submariner-gateway pod gets restarted, there is a brief datapath disruption until the new pod comes online. The cleanup code in submariner-gateway pod is not required as its handled by the route-agent code when there is any transition in the Gateway nodes. Partially fixes: submariner-io#2498 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
🤖 Created branch: z_pr2504/sridhargaddam/automated-backport-of-#2499-origin-release-0.15 |
maayanf24
approved these changes
Jun 1, 2023
skitt
approved these changes
Jun 1, 2023
🤖 Closed branches: [z_pr2504/sridhargaddam/automated-backport-of-#2499-origin-release-0.15] |
sridhargaddam
added a commit
to sridhargaddam/submariner-website
that referenced
this pull request
Jul 5, 2023
Submariner Gateway pod now skips invoking cableEngine cleanup during termination, as this is handled by the Route agent during gateway migration. Related to: submariner-io/submariner#2504 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
sridhargaddam
added a commit
to sridhargaddam/submariner-website
that referenced
this pull request
Jul 5, 2023
Submariner Gateway pod now skips invoking cableEngine cleanup during termination, as this is handled by the Route agent during gateway migration. Related to: submariner-io/submariner#2504 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
sridhargaddam
added a commit
to sridhargaddam/submariner-website
that referenced
this pull request
Jul 6, 2023
Submariner Gateway pod now skips invoking cableEngine cleanup during termination, as this is handled by the Route agent during gateway migration. Related to: submariner-io/submariner#2504 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
skitt
pushed a commit
to submariner-io/submariner-website
that referenced
this pull request
Jul 6, 2023
Submariner Gateway pod now skips invoking cableEngine cleanup during termination, as this is handled by the Route agent during gateway migration. Related to: submariner-io/submariner#2504 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
skitt
pushed a commit
to skitt/submariner-website
that referenced
this pull request
Jul 10, 2023
Submariner Gateway pod now skips invoking cableEngine cleanup during termination, as this is handled by the Route agent during gateway migration. Related to: submariner-io/submariner#2504 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
skitt
pushed a commit
to submariner-io/submariner-website
that referenced
this pull request
Jul 10, 2023
Submariner Gateway pod now skips invoking cableEngine cleanup during termination, as this is handled by the Route agent during gateway migration. Related to: submariner-io/submariner#2504 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
automated-backport
ready-to-test
When a PR is ready for full E2E testing
release-note-handled
release-note-needed
Should be mentioned in the release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #2499 on release-0.15.
#2499: Avoid cableEngine cleanup when the gateway pod is restarted
For details on the backport process, see the backport requests page.