Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated backport of #2499: Avoid cableEngine cleanup when the gateway pod is restarted #2504

Conversation

sridhargaddam
Copy link
Member

Backport of #2499 on release-0.15.

#2499: Avoid cableEngine cleanup when the gateway pod is restarted

For details on the backport process, see the backport requests page.

In the current code, it was seen that when the submariner-gateway
pod gets restarted, there is a brief datapath disruption until the
new pod comes online. The cleanup code in submariner-gateway pod is
not required as its handled by the route-agent code when there is
any transition in the Gateway nodes.

Partially fixes: submariner-io#2498
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr2504/sridhargaddam/automated-backport-of-#2499-origin-release-0.15
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@submariner-bot submariner-bot added the ready-to-test When a PR is ready for full E2E testing label Jun 1, 2023
@skitt skitt enabled auto-merge (rebase) June 1, 2023 13:22
@skitt skitt merged commit 2abc46e into submariner-io:release-0.15 Jun 1, 2023
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr2504/sridhargaddam/automated-backport-of-#2499-origin-release-0.15]

@dfarrell07 dfarrell07 added the release-note-needed Should be mentioned in the release notes label Jun 5, 2023
sridhargaddam added a commit to sridhargaddam/submariner-website that referenced this pull request Jul 5, 2023
Submariner Gateway pod now skips invoking cableEngine cleanup
during termination, as this is handled by the Route agent
during gateway migration.

Related to: submariner-io/submariner#2504
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
sridhargaddam added a commit to sridhargaddam/submariner-website that referenced this pull request Jul 5, 2023
Submariner Gateway pod now skips invoking cableEngine cleanup
during termination, as this is handled by the Route agent during
gateway migration.

Related to: submariner-io/submariner#2504
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
sridhargaddam added a commit to sridhargaddam/submariner-website that referenced this pull request Jul 6, 2023
Submariner Gateway pod now skips invoking cableEngine cleanup
during termination, as this is handled by the Route agent
during gateway migration.

Related to: submariner-io/submariner#2504
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
skitt pushed a commit to submariner-io/submariner-website that referenced this pull request Jul 6, 2023
Submariner Gateway pod now skips invoking cableEngine cleanup
during termination, as this is handled by the Route agent
during gateway migration.

Related to: submariner-io/submariner#2504
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
skitt pushed a commit to skitt/submariner-website that referenced this pull request Jul 10, 2023
Submariner Gateway pod now skips invoking cableEngine cleanup
during termination, as this is handled by the Route agent
during gateway migration.

Related to: submariner-io/submariner#2504
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
skitt pushed a commit to submariner-io/submariner-website that referenced this pull request Jul 10, 2023
Submariner Gateway pod now skips invoking cableEngine cleanup
during termination, as this is handled by the Route agent
during gateway migration.

Related to: submariner-io/submariner#2504
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated-backport ready-to-test When a PR is ready for full E2E testing release-note-handled release-note-needed Should be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants