Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use "escapeall" extension when formatting with mdpopups #2163

Merged
merged 2 commits into from
Jan 5, 2023

Conversation

rchl
Copy link
Member

@rchl rchl commented Jan 4, 2023

The motivation is provided in #2158 but basically both issues that we had that needed this extension don't seem to manifest itself anymore and there is a new #2158 issue that it causes.

Fixes #2158

@rchl
Copy link
Member Author

rchl commented Jan 4, 2023

Hmm, we might still want the 'hardbreak': True functionality from that extension but without any other logic. This is not currently possible. That's because in github's markdown a single \n creates new line but not in the flavor used by mdpopups.

hello\nworld renders with a newline on github but with a space in mdpopups.

@rchl rchl merged commit 438d0ed into main Jan 5, 2023
@rchl rchl deleted the fix/remove-escape branch January 5, 2023 09:30
rchl added a commit that referenced this pull request Jan 16, 2023
* main: (30 commits)
  Make Document Symbols behavior more consistent with built-in Goto Symbol (#2166)
  docs: fsautocomplete config - remove redundant argument (#2165)
  Allow missing window/workDoneProgress/create request from the server (#2159)
  Use "plaintext" language ID for plain text files (#2164)
  Improve type annotations (#2162)
  Don't use "escapeall" extension when formatting with mdpopups (#2163)
  Cut 1.21.0
  Fix inlay hint parts wrapping into multiple lines (#2153)
  Ensure commands triggered from minihtml run on correct view (#2154)
  Add "Source Action" entry to the "Edit" main menu (#2149)
  Add "Refactor" entry to the "Edit" main menu (#2141)
  fix completion documentation being parsed as markdown twice (#2146)
  when going to definition scroll to start of the region, not end (#2147)
  Auto-restart on server crashing, up to 5 times (#2145)
  improve performance of completion & signature request on typing (#2148)
  fix code lenses not updating after Undo (#2139)
  docs: fix mixed indentation in language servers configuration
  add missing Goto commands to Command Palette (#2140)
  docs: add missing keyboard shortcuts (#2143)
  Pass force_group to LocationPicker (#2134)
  ...
rchl added a commit to jwortmann/LSP that referenced this pull request Jan 22, 2023
* main:
  workaround for View Listeners not being attached for new transient view (sublimelsp#2174)
  Make Document Symbols behavior more consistent with built-in Goto Symbol (sublimelsp#2166)
  docs: fsautocomplete config - remove redundant argument (sublimelsp#2165)
  Allow missing window/workDoneProgress/create request from the server (sublimelsp#2159)
  Use "plaintext" language ID for plain text files (sublimelsp#2164)
  Improve type annotations (sublimelsp#2162)
  Don't use "escapeall" extension when formatting with mdpopups (sublimelsp#2163)
rchl added a commit that referenced this pull request Jan 31, 2023
* main: (80 commits)
  Perform inlay hint action on double instead of single click (#2175)
  support canceling pending completions request (#2177)
  Implement type hierarchy request (#2180)
  fix stale state or lack of updates on changing branches (#2182)
  Add timestamp and request duration in LSP logs (#2181)
  don't show diagnostics panel on save by default (#2179)
  trigger "on_server_response_async" also for "initialize" response (#2172)
  feat(API): allow setting additional text in permanent server status (#2173)
  Implement call hierarchy request (#2151)
  workaround for View Listeners not being attached for new transient view (#2174)
  Make Document Symbols behavior more consistent with built-in Goto Symbol (#2166)
  docs: fsautocomplete config - remove redundant argument (#2165)
  Allow missing window/workDoneProgress/create request from the server (#2159)
  Use "plaintext" language ID for plain text files (#2164)
  Improve type annotations (#2162)
  Don't use "escapeall" extension when formatting with mdpopups (#2163)
  Cut 1.21.0
  Fix inlay hint parts wrapping into multiple lines (#2153)
  Ensure commands triggered from minihtml run on correct view (#2154)
  Add "Source Action" entry to the "Edit" main menu (#2149)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backslash in hover popup is not shown
2 participants