improve performance of completion & signature request on typing #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchl
changed the title
|
Disable showing whitespace changes if the diff is hard to read. |
predragnikolic
approved these changes
Dec 21, 2022
rchl
changed the title
rchl
added a commit
that referenced
this pull request
Jan 16, 2023
* main: (30 commits) Make Document Symbols behavior more consistent with built-in Goto Symbol (#2166) docs: fsautocomplete config - remove redundant argument (#2165) Allow missing window/workDoneProgress/create request from the server (#2159) Use "plaintext" language ID for plain text files (#2164) Improve type annotations (#2162) Don't use "escapeall" extension when formatting with mdpopups (#2163) Cut 1.21.0 Fix inlay hint parts wrapping into multiple lines (#2153) Ensure commands triggered from minihtml run on correct view (#2154) Add "Source Action" entry to the "Edit" main menu (#2149) Add "Refactor" entry to the "Edit" main menu (#2141) fix completion documentation being parsed as markdown twice (#2146) when going to definition scroll to start of the region, not end (#2147) Auto-restart on server crashing, up to 5 times (#2145) improve performance of completion & signature request on typing (#2148) fix code lenses not updating after Undo (#2139) docs: fix mixed indentation in language servers configuration add missing Goto commands to Command Palette (#2140) docs: add missing keyboard shortcuts (#2143) Pass force_group to LocationPicker (#2134) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before triggering completion or signature request, we are forcing a
purge_changes_async()because we have to. This immediately triggered various non-essential requests like semantic highlighting, inline hints, document link, color boxes which can dramatically reduce responsiveness due to those requests jumping in front of the queue. Instead trigger those in the next "tick" so that the completion/signature requests are triggered first.Before those changes (with semantic highlighting enabled and being the main reason for worse responsiveness):
Screen.Recording.2022-12-21.at.15.23.32.mov
With those changes:
Screen.Recording.2022-12-21.at.15.22.28.mov