Allow missing window/workDoneProgress/create request from the server #2159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a workaround for servers that report server-initiated progress but don't request window/workDoneProgress/create before reporting progress.
|
It's nothing new in this PR but we shouldn't be relying on destructor for updating the UI as destructor is not guaranteed to run immediately and that can result in progress lingering for longer than necessary. For example, this was easily visible before (and still is for some features) when restarting the server. Regions would keep showing for a second or so after restarting a server on my system. |
|
I understand the concern but I don't quite know how to address it. |
rchl
reviewed
Jan 2, 2023
LDAP
approved these changes
Jan 4, 2023
rchl
approved these changes
Jan 5, 2023
rchl
added a commit
that referenced
this pull request
Jan 16, 2023
* main: (30 commits) Make Document Symbols behavior more consistent with built-in Goto Symbol (#2166) docs: fsautocomplete config - remove redundant argument (#2165) Allow missing window/workDoneProgress/create request from the server (#2159) Use "plaintext" language ID for plain text files (#2164) Improve type annotations (#2162) Don't use "escapeall" extension when formatting with mdpopups (#2163) Cut 1.21.0 Fix inlay hint parts wrapping into multiple lines (#2153) Ensure commands triggered from minihtml run on correct view (#2154) Add "Source Action" entry to the "Edit" main menu (#2149) Add "Refactor" entry to the "Edit" main menu (#2141) fix completion documentation being parsed as markdown twice (#2146) when going to definition scroll to start of the region, not end (#2147) Auto-restart on server crashing, up to 5 times (#2145) improve performance of completion & signature request on typing (#2148) fix code lenses not updating after Undo (#2139) docs: fix mixed indentation in language servers configuration add missing Goto commands to Command Palette (#2140) docs: add missing keyboard shortcuts (#2143) Pass force_group to LocationPicker (#2134) ...
rchl
added a commit
to jwortmann/LSP
that referenced
this pull request
Jan 22, 2023
* main: workaround for View Listeners not being attached for new transient view (sublimelsp#2174) Make Document Symbols behavior more consistent with built-in Goto Symbol (sublimelsp#2166) docs: fsautocomplete config - remove redundant argument (sublimelsp#2165) Allow missing window/workDoneProgress/create request from the server (sublimelsp#2159) Use "plaintext" language ID for plain text files (sublimelsp#2164) Improve type annotations (sublimelsp#2162) Don't use "escapeall" extension when formatting with mdpopups (sublimelsp#2163)
rchl
added a commit
that referenced
this pull request
Jan 31, 2023
* main: (80 commits) Perform inlay hint action on double instead of single click (#2175) support canceling pending completions request (#2177) Implement type hierarchy request (#2180) fix stale state or lack of updates on changing branches (#2182) Add timestamp and request duration in LSP logs (#2181) don't show diagnostics panel on save by default (#2179) trigger "on_server_response_async" also for "initialize" response (#2172) feat(API): allow setting additional text in permanent server status (#2173) Implement call hierarchy request (#2151) workaround for View Listeners not being attached for new transient view (#2174) Make Document Symbols behavior more consistent with built-in Goto Symbol (#2166) docs: fsautocomplete config - remove redundant argument (#2165) Allow missing window/workDoneProgress/create request from the server (#2159) Use "plaintext" language ID for plain text files (#2164) Improve type annotations (#2162) Don't use "escapeall" extension when formatting with mdpopups (#2163) Cut 1.21.0 Fix inlay hint parts wrapping into multiple lines (#2153) Ensure commands triggered from minihtml run on correct view (#2154) Add "Source Action" entry to the "Edit" main menu (#2149) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a workaround for servers that report server-initiated progress but don't request window/workDoneProgress/create before reporting progress.
I haven't actually tested whether this works with jdlts regarding its progress reporting behavior in sublimelsp/LSP-jdtls#37, could you check @LDAP ?