Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workaround for View Listeners not being attached for new transient view #2174

Merged
merged 2 commits into from
Jan 22, 2023

Conversation

rchl
Copy link
Member

@rchl rchl commented Jan 22, 2023

Workaround for core issue sublimehq/sublime_text#2411

Fixes #1979

@rchl rchl changed the title workaround View listeners not being attached for opened transient view workaround for View Listeners not being attached for opened transient view Jan 22, 2023
@rchl rchl changed the title workaround for View Listeners not being attached for opened transient view workaround for View Listeners not being attached for new transient view Jan 22, 2023
plugin/core/open.py Outdated Show resolved Hide resolved
@predragnikolic
Copy link
Member

tested ✔️

Co-authored-by: Предраг Николић <idmpepe@gmail.com>
@rchl rchl merged commit ff57279 into main Jan 22, 2023
@rchl rchl deleted the fix/workaround-view-listeners branch January 22, 2023 19:57
rchl added a commit to jwortmann/LSP that referenced this pull request Jan 22, 2023
* main:
  workaround for View Listeners not being attached for new transient view (sublimelsp#2174)
  Make Document Symbols behavior more consistent with built-in Goto Symbol (sublimelsp#2166)
  docs: fsautocomplete config - remove redundant argument (sublimelsp#2165)
  Allow missing window/workDoneProgress/create request from the server (sublimelsp#2159)
  Use "plaintext" language ID for plain text files (sublimelsp#2164)
  Improve type annotations (sublimelsp#2162)
  Don't use "escapeall" extension when formatting with mdpopups (sublimelsp#2163)
rchl added a commit that referenced this pull request Jan 22, 2023
* origin/main:
  feat(API): allow setting additional text in permanent server status (#2173)
  Implement call hierarchy request (#2151)
  workaround for View Listeners not being attached for new transient view (#2174)
rchl added a commit that referenced this pull request Jan 31, 2023
* main: (80 commits)
  Perform inlay hint action on double instead of single click (#2175)
  support canceling pending completions request (#2177)
  Implement type hierarchy request (#2180)
  fix stale state or lack of updates on changing branches (#2182)
  Add timestamp and request duration in LSP logs (#2181)
  don't show diagnostics panel on save by default (#2179)
  trigger "on_server_response_async" also for "initialize" response (#2172)
  feat(API): allow setting additional text in permanent server status (#2173)
  Implement call hierarchy request (#2151)
  workaround for View Listeners not being attached for new transient view (#2174)
  Make Document Symbols behavior more consistent with built-in Goto Symbol (#2166)
  docs: fsautocomplete config - remove redundant argument (#2165)
  Allow missing window/workDoneProgress/create request from the server (#2159)
  Use "plaintext" language ID for plain text files (#2164)
  Improve type annotations (#2162)
  Don't use "escapeall" extension when formatting with mdpopups (#2163)
  Cut 1.21.0
  Fix inlay hint parts wrapping into multiple lines (#2153)
  Ensure commands triggered from minihtml run on correct view (#2154)
  Add "Source Action" entry to the "Edit" main menu (#2149)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

side_by_side feature sometimes works
2 participants