fix code lenses not updating after Undo #2139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note on |
|
Changed Debouncer to be not thread-safe as we don't currently seem to have a need for thread safe version. |
|
No complains I guess. :) |
rchl
changed the title
rchl
added a commit
that referenced
this pull request
Jan 16, 2023
* main: (30 commits) Make Document Symbols behavior more consistent with built-in Goto Symbol (#2166) docs: fsautocomplete config - remove redundant argument (#2165) Allow missing window/workDoneProgress/create request from the server (#2159) Use "plaintext" language ID for plain text files (#2164) Improve type annotations (#2162) Don't use "escapeall" extension when formatting with mdpopups (#2163) Cut 1.21.0 Fix inlay hint parts wrapping into multiple lines (#2153) Ensure commands triggered from minihtml run on correct view (#2154) Add "Source Action" entry to the "Edit" main menu (#2149) Add "Refactor" entry to the "Edit" main menu (#2141) fix completion documentation being parsed as markdown twice (#2146) when going to definition scroll to start of the region, not end (#2147) Auto-restart on server crashing, up to 5 times (#2145) improve performance of completion & signature request on typing (#2148) fix code lenses not updating after Undo (#2139) docs: fix mixed indentation in language servers configuration add missing Goto commands to Command Palette (#2140) docs: add missing keyboard shortcuts (#2143) Pass force_group to LocationPicker (#2134) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating of code lenses should IMO not be tied to selection update as document can get modified programmatically in which case selection might not change.
There is also another weird case where I've noticed this issue during "Undo" and that one has deeper roots... When undoing removal of a line,
on_text_changed_asyncis quickly called twice and on the first call selection isdifferentfrom the stored one but on the second call, it's not. That results in_when_selection_remains_stable_asyncnot being triggered (first time because region no longer matches indebouncedand second time becausedifferentisFalseso we return early fromon_text_changed_async). This is an issue that should still be fixed but it's fairly minor and probably doesn't even effect_do_highlights_asyncmuch.That said, switching to
Debouncerclass avoids the above issue affecting code lenses.(I guess we might be a bit concerned about using locks in more places but I think and hope that it's not really that expensive. Especially as
Debounceris only holding the lock to update a single property.)Fixes #2136