Make reattest to renew default behaviour #4791

faisal-memon · 2024-01-11T21:00:00Z

Pull Request check list

Commit conforms to CONTRIBUTING.md?
Proper tests/regressions included?
Documentation updated?

Affected functionality

How agent handles certificate expiration

Description of change

Make reattest default behavior for renewing svid for environments that support reattesting.

Which issue this PR fixes

fixes #4658

faisal-memon · 2024-01-11T23:43:29Z

Looks like the x509 pop tests are failing because they need to reattest now.

[2024-01-11T21:14:05Z] running x509pop test...
2024/01/11 21:14:06 Watching X.509 contexts
2024/01/11 21:14:06 Attesting agent...
2024/01/11 21:14:06 Renewing agent...
2024/01/11 21:14:06 Node attestation client failed: failed to renew agent: failed to renew agent: rpc error: code = PermissionDenied desc = agent can't renew SVID, must reattest
[2024-01-11T21:14:06Z] failed to check x509pop attestion
[2024-01-11T21:14:06Z] step 04-test-x509pop-attestation failed

faisal-memon · 2024-01-11T23:57:18Z

I think its this section here:

spire/test/integration/setup/node-attestation/client.go

Lines 216 to 219 in 4b15b04

    
           // Renew agent 
        
           if err := x509popRenew(ctx, svidResp); err != nil { 
        
           	return fmt.Errorf("failed to renew agent: %w", err) 
        
           }

We should either remove or invert the logic so that we expect to get an error back.

faisal-memon · 2024-01-16T19:41:50Z

Seems like a transient failure:

tar xvf images.tar.gz
  make load-images
  shell: /usr/bin/bash -e {0}
  env:
    GO_VERSION: 1.21.[5](https://github.com/spiffe/spire/actions/runs/7546181593/job/20543643786?pr=4791#step:8:5)
oidc-discovery-provider-image.tar
spire-agent-image.tar
spire-server-image.tar

gzip: stdin: unexpected end of file
tar: Unexpected EOF in archive
tar: Unexpected EOF in archive
tar: Error is not recoverable: exiting now

MarcosDY · 2024-01-24T13:45:32Z

we are making reattest default, but we are not allowing a way to disable this (in case someone get into an error and they must disable this feature),
what do you think about adding a deprecated configuration to disable reattestation? and we can remove that configuration in 1.10?

amartinezfayo · 2024-01-26T19:38:16Z

pkg/server/api/agent/v1/service.go

-	if attestedNode.CanReattest && fflag.IsSet(fflag.FlagReattestToRenew) {
-		return nil, errorutil.PermissionDenied(types.PermissionDeniedDetails_AGENT_MUST_REATTEST, "agent can't renew SVID, must reattest")
+	if attestedNode.CanReattest {
+		log.Warn("Agent renewing SVID when it should be reattesting")


1.8.x agents calling this API will always trigger this warning unless they have the feature flag enabled.
It doesn't seem that we can safely enforce reattestation until 1.10 without breaking existing agents.
We should probably just add a TODO comment here to change this to return an error in v1.10.

amartinezfayo

Thank you @faisal-memon for your patience on the review. I have one more comment about documenting the setting being introduced.

amartinezfayo · 2024-02-01T20:11:51Z

cmd/spire-agent/cli/run/run.go

@@ -103,6 +103,9 @@ type agentConfig struct {
 	Experimental     experimentalConfig `hcl:"experimental"`

 	UnusedKeyPositions map[string][]token.Pos `hcl:",unusedKeyPositions"`
+
+	// Deprecated configurables
+	DisableReattestToRenew bool `hcl:"disable_reattest_to_renew"`


We should have this documented in spire_agent.md and agent_full.conf.

@amartinezfayo docs updated.

amartinezfayo

Thank you @faisal-memon!

amartinezfayo · 2024-02-07T17:58:35Z

Hey @faisal-memon DCO check is failing:

Commit sha: [fb1b954](https://github.com/spiffe/spire/pull/4791/commits/fb1b954d3b58a1d3f0b9967ce8179ff46798703f), Author: Faisal Memon, Committer: Faisal Memon; The sign-off is missing.

Could you please address that?

Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Bumps [github.com/cloudflare/circl](https://github.com/cloudflare/circl) from 1.3.5 to 1.3.7. - [Release notes](https://github.com/cloudflare/circl/releases) - [Commits](cloudflare/circl@v1.3.5...v1.3.7) --- updated-dependencies: - dependency-name: github.com/cloudflare/circl dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.19.0 to 0.20.0. - [Commits](golang/net@v0.19.0...v0.20.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Cf. "crane digest docker/dockerfile:1.6.0" vs "crane digest --platform linux/amd64 docker/dockerfile:1.6.0" Signed-off-by: Jürgen Kreileder <jk@blackdown.de> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Bumps [actions/cache](https://github.com/actions/cache) from 3.3.2 to 4.0.0. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@704facf...13aacd8) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Bumps [github.com/lestrrat-go/jwx/v2](https://github.com/lestrrat-go/jwx) from 2.0.18 to 2.0.19. - [Release notes](https://github.com/lestrrat-go/jwx/releases) - [Changelog](https://github.com/lestrrat-go/jwx/blob/develop/v2/Changes) - [Commits](lestrrat-go/jwx@v2.0.18...v2.0.19) --- updated-dependencies: - dependency-name: github.com/lestrrat-go/jwx/v2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.0.0 to 4.1.0. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@c7d193f...1eb3cb2) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Signed-off-by: Sorin Dumitru <sdumitru@bloomberg.net> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@f44cd7b...6b208ae) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

) Bumps [github.com/open-policy-agent/opa](https://github.com/open-policy-agent/opa) from 0.59.0 to 0.60.0. - [Release notes](https://github.com/open-policy-agent/opa/releases) - [Changelog](https://github.com/open-policy-agent/opa/blob/main/CHANGELOG.md) - [Commits](open-policy-agent/opa@v0.59.0...v0.60.0) --- updated-dependencies: - dependency-name: github.com/open-policy-agent/opa dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

This test is racy because it currently relies on timing of several goroutines and context cancellation. The notifier doing context cancellation doesn't seem to test anything useful. I don't recall why it was even added. Getting rid of the context cancellation and simply asserting that the function returns nil when the notifier returns nil seems good enough. Signed-off-by: Andrew Harding <azdagron@gmail.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

* Fix racy tests that test streaming RPCs Signed-off-by: Andrew Harding <azdagron@gmail.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

* peertracker: close connection when IsAlive fails The listener now wraps the platform-specific watcher with one that closes the underlying connection when the IsAlive check fails in order to kill the transport to the caller, who is no longer trusted. Fixes: spiffe#4665 Signed-off-by: Andrew Harding <azdagron@gmail.com> * relax error check Signed-off-by: Andrew Harding <azdagron@gmail.com> --------- Signed-off-by: Andrew Harding <azdagron@gmail.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

) Bumps [github.com/open-policy-agent/opa](https://github.com/open-policy-agent/opa) from 0.60.0 to 0.61.0. - [Release notes](https://github.com/open-policy-agent/opa/releases) - [Changelog](https://github.com/open-policy-agent/opa/blob/main/CHANGELOG.md) - [Commits](open-policy-agent/opa@v0.60.0...v0.61.0) --- updated-dependencies: - dependency-name: github.com/open-policy-agent/opa dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Bumps [github.com/hashicorp/vault/api](https://github.com/hashicorp/vault) from 1.10.0 to 1.11.0. - [Release notes](https://github.com/hashicorp/vault/releases) - [Changelog](https://github.com/hashicorp/vault/blob/main/CHANGELOG.md) - [Commits](hashicorp/vault@v1.10.0...v1.11.0) --- updated-dependencies: - dependency-name: github.com/hashicorp/vault/api dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

…mpatible (spiffe#4833) * Bump github.com/docker/docker Bumps [github.com/docker/docker](https://github.com/docker/docker) from 24.0.7+incompatible to 25.0.1+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v24.0.7...v25.0.1) --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * update unit test Signed-off-by: Andrew Harding <azdagron@gmail.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Andrew Harding <azdagron@gmail.com> Co-authored-by: Andrew Harding <azdagron@gmail.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Bumps the aws-sdk group with 1 update: [github.com/aws/aws-sdk-go-v2/service/ec2](https://github.com/aws/aws-sdk-go-v2). Updates `github.com/aws/aws-sdk-go-v2/service/ec2` from 1.145.0 to 1.146.0 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@service/ec2/v1.145.0...service/ec2/v1.146.0) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/service/ec2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: aws-sdk ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

* Add pagination support to events based cache Signed-off-by: Faisal Memon <fymemon@yahoo.com>

…iffe#4849) Bumps [github.com/google/go-containerregistry](https://github.com/google/go-containerregistry) from 0.18.0 to 0.19.0. - [Release notes](https://github.com/google/go-containerregistry/releases) - [Changelog](https://github.com/google/go-containerregistry/blob/main/.goreleaser.yml) - [Commits](google/go-containerregistry@v0.18.0...v0.19.0) --- updated-dependencies: - dependency-name: github.com/google/go-containerregistry dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.159.0 to 0.161.0. - [Release notes](https://github.com/googleapis/google-api-go-client/releases) - [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md) - [Commits](googleapis/google-api-go-client@v0.159.0...v0.161.0) --- updated-dependencies: - dependency-name: google.golang.org/api dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Bumps [github.com/mattn/go-sqlite3](https://github.com/mattn/go-sqlite3) from 1.14.20 to 1.14.21. - [Release notes](https://github.com/mattn/go-sqlite3/releases) - [Commits](mattn/go-sqlite3@v1.14.20...v1.14.21) --- updated-dependencies: - dependency-name: github.com/mattn/go-sqlite3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

…#4852) * LRU subscribers failed to start when no selector was provided Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Bumps [sigstore/cosign-installer](https://github.com/sigstore/cosign-installer) from 3.3.0 to 3.4.0. - [Release notes](https://github.com/sigstore/cosign-installer/releases) - [Commits](sigstore/cosign-installer@9614fae...e1523de) --- updated-dependencies: - dependency-name: sigstore/cosign-installer dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Bumps [github.com/shirou/gopsutil/v3](https://github.com/shirou/gopsutil) from 3.23.12 to 3.24.1. - [Release notes](https://github.com/shirou/gopsutil/releases) - [Commits](shirou/gopsutil@v3.23.12...v3.24.1) --- updated-dependencies: - dependency-name: github.com/shirou/gopsutil/v3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

…estor (spiffe#4841) Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Bumps [github.com/docker/docker](https://github.com/docker/docker) from 25.0.1+incompatible to 25.0.2+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v25.0.1...v25.0.2) --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

* Set a default admin socket path for spire-agent cli use Set a standard default location the spire-agent cli will use to look for the agent socket when using commands against the spire-agent daemon. Actual functionality needing this variable will come in future patches. Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Incorperate feedback Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> * Fix filename Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> --------- Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Bumps [github.com/mattn/go-sqlite3](https://github.com/mattn/go-sqlite3) from 1.14.21 to 1.14.22. - [Release notes](https://github.com/mattn/go-sqlite3/releases) - [Commits](mattn/go-sqlite3@v1.14.21...v1.14.22) --- updated-dependencies: - dependency-name: github.com/mattn/go-sqlite3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

…4868) For consistency sake, the initial state should be loaded from the main database instance and not from read replicas. Signed-off-by: Andrew Harding <azdagron@gmail.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Bumps [github.com/sigstore/rekor](https://github.com/sigstore/rekor) from 1.3.4 to 1.3.5. - [Release notes](https://github.com/sigstore/rekor/releases) - [Changelog](https://github.com/sigstore/rekor/blob/main/CHANGELOG.md) - [Commits](sigstore/rekor@v1.3.4...v1.3.5) --- updated-dependencies: - dependency-name: github.com/sigstore/rekor dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Bumps the azure-sdk group with 1 update: [github.com/Azure/azure-sdk-for-go/sdk/azcore](https://github.com/Azure/azure-sdk-for-go). Updates `github.com/Azure/azure-sdk-for-go/sdk/azcore` from 1.9.1 to 1.9.2 - [Release notes](https://github.com/Azure/azure-sdk-for-go/releases) - [Changelog](https://github.com/Azure/azure-sdk-for-go/blob/main/documentation/release.md) - [Commits](Azure/azure-sdk-for-go@sdk/azcore/v1.9.1...sdk/azcore/v1.9.2) --- updated-dependencies: - dependency-name: github.com/Azure/azure-sdk-for-go/sdk/azcore dependency-type: direct:production update-type: version-update:semver-patch dependency-group: azure-sdk ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.161.0 to 0.162.0. - [Release notes](https://github.com/googleapis/google-api-go-client/releases) - [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md) - [Commits](googleapis/google-api-go-client@v0.161.0...v0.162.0) --- updated-dependencies: - dependency-name: google.golang.org/api dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

* No longer emit x509UniqueIdentifier in X509-SVIDs Introduced in 1.4.2, this practice has turned out to be problematic. This change updates SPIRE Server to no long emit attribute in the X509-SVID subject. It also introduces a new built-in CredentialComposer to add the attribute back in for deployments that rely on it. The plugin only augments workload X509-SVIDs. Server and agent X509-SVIDs are not modified. Fixes: spiffe#4755 Fixes: spiffe#3110 Signed-off-by: Andrew Harding <azdagron@gmail.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

faisal-memon · 2024-02-07T19:14:23Z

Hey @faisal-memon DCO check is failing:

Commit sha: [fb1b954](https://github.com/spiffe/spire/pull/4791/commits/fb1b954d3b58a1d3f0b9967ce8179ff46798703f), Author: Faisal Memon, Committer: Faisal Memon; The sign-off is missing.

Could you please address that?

@amartinezfayo done

* Make reattest to renew default behaviour Signed-off-by: Faisal Memon <fymemon@yahoo.com>

faisal-memon requested review from evan2645, amartinezfayo, azdagron, MarcosDY and rturner3 as code owners January 11, 2024 21:00

azdagron added this to the 1.9.0 milestone Jan 16, 2024

azdagron assigned amartinezfayo Jan 16, 2024

amartinezfayo reviewed Jan 26, 2024

View reviewed changes

amartinezfayo reviewed Feb 1, 2024

View reviewed changes

amartinezfayo approved these changes Feb 7, 2024

View reviewed changes

faisal-memon and others added 15 commits February 7, 2024 11:13

Make reattest to renew default behaviour

e30be25

Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Fix x509 pop test

eccc8a1

Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Convert renew when should reattest to warn

450b6ba

Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Pin docker/dockerfile:1.6.0 with multi-platform sha256 (spiffe#4766)

86902b0

Cf. "crane digest docker/dockerfile:1.6.0" vs "crane digest --platform linux/amd64 docker/dockerfile:1.6.0" Signed-off-by: Jürgen Kreileder <jk@blackdown.de> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Fetch agent selectors when refreshing event based cache (spiffe#4803)

9a51431

Signed-off-by: Sorin Dumitru <sdumitru@bloomberg.net> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Fix racy tests that test streaming RPCs (spiffe#4810)

1c15430

* Fix racy tests that test streaming RPCs Signed-off-by: Andrew Harding <azdagron@gmail.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

dependabot bot and others added 20 commits February 7, 2024 11:13

Add pagination support to events based cache (spiffe#4826)

addf533

* Add pagination support to events based cache Signed-off-by: Faisal Memon <fymemon@yahoo.com>

LRU subscribers failed to start when no selector was provided (spiffe…

85ce567

…#4852) * LRU subscribers failed to start when no selector was provided Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Deprecate the k8s_sat node attestor in favor of the k8s_psat node att…

4d5df8f

…estor (spiffe#4841) Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

faisal-memon force-pushed the reattest branch from 51753e3 to beb7292 Compare February 7, 2024 19:13

Merge branch 'main' into reattest

a0f2956

amartinezfayo merged commit 9b09e0f into spiffe:main Feb 7, 2024
32 checks passed

faisal-memon added a commit to faisal-memon/spire that referenced this pull request Feb 9, 2024

Make reattest to renew default behaviour (spiffe#4791)

3607ff2

* Make reattest to renew default behaviour Signed-off-by: Faisal Memon <fymemon@yahoo.com>

kfox1111 mentioned this pull request Feb 22, 2024

SPIRE 1.9 support spiffe/helm-charts-hardened#261

Closed

sriyer pushed a commit to spire-vault/spire that referenced this pull request Feb 23, 2024

Make reattest to renew default behaviour (spiffe#4791)

4b7fb55

* Make reattest to renew default behaviour Signed-off-by: Faisal Memon <fymemon@yahoo.com>

evan2645 mentioned this pull request Mar 5, 2024

Run SPIRE Agent on top of k8s as a workload sidecar #4804

Open

rushi47 pushed a commit to rushi47/spire that referenced this pull request Apr 11, 2024

Make reattest to renew default behaviour (spiffe#4791)

46cc26a

* Make reattest to renew default behaviour Signed-off-by: Faisal Memon <fymemon@yahoo.com>

faisal-memon deleted the reattest branch July 4, 2024 00:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make reattest to renew default behaviour #4791

Make reattest to renew default behaviour #4791

faisal-memon commented Jan 11, 2024

faisal-memon commented Jan 11, 2024

faisal-memon commented Jan 11, 2024

faisal-memon commented Jan 16, 2024

MarcosDY commented Jan 24, 2024

amartinezfayo Jan 26, 2024

amartinezfayo left a comment

amartinezfayo Feb 1, 2024

faisal-memon Feb 6, 2024

amartinezfayo left a comment

amartinezfayo commented Feb 7, 2024

faisal-memon commented Feb 7, 2024

Make reattest to renew default behaviour #4791

Make reattest to renew default behaviour #4791

Conversation

faisal-memon commented Jan 11, 2024

faisal-memon commented Jan 11, 2024

faisal-memon commented Jan 11, 2024

faisal-memon commented Jan 16, 2024

MarcosDY commented Jan 24, 2024

amartinezfayo Jan 26, 2024

Choose a reason for hiding this comment

amartinezfayo left a comment

Choose a reason for hiding this comment

amartinezfayo Feb 1, 2024

Choose a reason for hiding this comment

faisal-memon Feb 6, 2024

Choose a reason for hiding this comment

amartinezfayo left a comment

Choose a reason for hiding this comment

amartinezfayo commented Feb 7, 2024

faisal-memon commented Feb 7, 2024