Add pagination support to events based cache #4826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Faisal Memon <fymemon@yahoo.com>
azdagron
reviewed
Jan 26, 2024
There was a problem hiding this comment.
Thanks @faisal-memon! Looks good. Paging behavior should probably be covered by a unit test before we merge.
Signed-off-by: Faisal Memon <fymemon@yahoo.com>
faisal-memon
requested review from
evan2645,
amartinezfayo,
MarcosDY and
rturner3
as code owners
@azdagron Thanks for reviewing. Added the unit tests and moved this out of draft. |
azdagron
approved these changes
Jan 30, 2024
faisal-memon
added a commit
to faisal-memon/spire
that referenced
this pull request
Feb 7, 2024
* Add pagination support to events based cache Signed-off-by: Faisal Memon <fymemon@yahoo.com>
sriyer
pushed a commit
to spire-vault/spire
that referenced
this pull request
Feb 23, 2024
* Add pagination support to events based cache Signed-off-by: Faisal Memon <fymemon@yahoo.com>
rushi47
pushed a commit
to rushi47/spire
that referenced
this pull request
Apr 11, 2024
* Add pagination support to events based cache Signed-off-by: Faisal Memon <fymemon@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check list
Affected functionality
Events based cache
Description of change
The events based cache lists all entries on start up. This change paginates that initial list entries request.
Marking as draft until I have some unit tests for it.Which issue this PR fixes
fixes #4735