Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the k8s_sat node attestor in favor of the k8s_psat node attestor #4841

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

amartinezfayo
Copy link
Member

Deprecate the k8s_sat node attestor in favor of the k8s_psat node attestor.

Fixes #3495.

…estor

Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
@rturner3 rturner3 self-assigned this Jan 30, 2024
Copy link
Collaborator

@rturner3 rturner3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, couple optional nits

pkg/agent/plugin/nodeattestor/k8ssat/sat.go Show resolved Hide resolved
pkg/server/plugin/nodeattestor/k8ssat/sat.go Show resolved Hide resolved
@rturner3 rturner3 merged commit 085199e into spiffe:main Feb 1, 2024
32 checks passed
faisal-memon pushed a commit to faisal-memon/spire that referenced this pull request Feb 7, 2024
…estor (spiffe#4841)

Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
Signed-off-by: Faisal Memon <fymemon@yahoo.com>
sriyer pushed a commit to spire-vault/spire that referenced this pull request Feb 23, 2024
…estor (spiffe#4841)

Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
rushi47 pushed a commit to rushi47/spire that referenced this pull request Apr 11, 2024
…estor (spiffe#4841)

Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate k8s_sat attestor
2 participants