LRU subscribers failed to start when no selector was provided #4852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com>
MarcosDY
requested review from
evan2645,
amartinezfayo,
azdagron and
rturner3
as code owners
Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com>
There was a problem hiding this comment.
Thank you @MarcosDY for this fix! I tested it in my environment and fixed the issue.
It's also good that you removed the debug messages "Updating SVIDs..." that were being logged every 5 seconds and now is logged when it's needed only.
I have only very small suggestions.
| subErrCh <- nil | ||
| }() | ||
|
|
||
| // Wait until subscribe is created and got a notification |
There was a problem hiding this comment.
Suggested change
| // Wait until subscribe is created and got a notification | |
| // Wait until subscriber is created and got a notification |
| } | ||
|
|
||
| if len(u1.Bundle.X509Authorities()) != 1 { | ||
| subErrCh <- fmt.Errorf("a single bundle is expected") |
There was a problem hiding this comment.
Suggested change
| subErrCh <- fmt.Errorf("a single bundle is expected") | |
| subErrCh <- fmt.Errorf("a single bundle is expected but got %d", len(u1.Bundle.X509Authorities())) |
Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com>
amartinezfayo
approved these changes
Jan 31, 2024
faisal-memon
pushed a commit
to faisal-memon/spire
that referenced
this pull request
Feb 7, 2024
…#4852) * LRU subscribers failed to start when no selector was provided Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>
sriyer
pushed a commit
to spire-vault/spire
that referenced
this pull request
Feb 23, 2024
…#4852) * LRU subscribers failed to start when no selector was provided Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com>
rushi47
pushed a commit
to rushi47/spire
that referenced
this pull request
Apr 11, 2024
…#4852) * LRU subscribers failed to start when no selector was provided Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LRU was failing into no returning notifications when no selector was found on attestation process,
this caused regular healthchecks to fail.
Used this opportunity to no longer add debug logs when no SVID was updated on LRU
Which issue this PR fixes
fixes #4827