Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use read-replicas for initial events-based cache load #4868

Merged

Conversation

azdagron
Copy link
Member

@azdagron azdagron commented Feb 6, 2024

For consistency sake, the initial state should be loaded from the main database instance and not from read replicas.

For consistency sake, the initial state should be loaded from the main
database instance and not from read replicas.

Signed-off-by: Andrew Harding <azdagron@gmail.com>
@azdagron azdagron added this to the 1.9.0 milestone Feb 6, 2024
Copy link
Member

@amartinezfayo amartinezfayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @azdagron!

@amartinezfayo amartinezfayo merged commit 30c4994 into spiffe:main Feb 6, 2024
32 checks passed
faisal-memon pushed a commit to faisal-memon/spire that referenced this pull request Feb 7, 2024
…4868)

For consistency sake, the initial state should be loaded from the main
database instance and not from read replicas.

Signed-off-by: Andrew Harding <azdagron@gmail.com>
Signed-off-by: Faisal Memon <fymemon@yahoo.com>
faisal-memon pushed a commit to faisal-memon/spire that referenced this pull request Feb 9, 2024
…4868)

For consistency sake, the initial state should be loaded from the main
database instance and not from read replicas.

Signed-off-by: Andrew Harding <azdagron@gmail.com>
Signed-off-by: Faisal Memon <fymemon@yahoo.com>
sriyer pushed a commit to spire-vault/spire that referenced this pull request Feb 23, 2024
…4868)

For consistency sake, the initial state should be loaded from the main
database instance and not from read replicas.

Signed-off-by: Andrew Harding <azdagron@gmail.com>
rushi47 pushed a commit to rushi47/spire that referenced this pull request Apr 11, 2024
…4868)

For consistency sake, the initial state should be loaded from the main
database instance and not from read replicas.

Signed-off-by: Andrew Harding <azdagron@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants