Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2023.7 #1187

Merged
merged 6 commits into from
Oct 4, 2023
Merged

2023.7 #1187

merged 6 commits into from
Oct 4, 2023

Conversation

javierggt
Copy link
Contributor

@javierggt javierggt commented Sep 18, 2023

ska3-flight 2023.7

This PR includes:

  • A list of packages is being removed from ska3-flight. These packages, which have a narrow scope an audience, will be grouped in a separate category and installed separately. In order to improve flexibility and reduce unnecessary labor of full FSDS review, these packages will be delegated from FSDS control to a lower level (see here)
  • One new package: chandra_limits, a package for limit management.
  • Changes to proseco, sparkles and starcheck to make the ACA penalty limit optional. This should be accompanied by a corresponding PR in chandra_models
  • Changes in parse_cm to handle machine-readable comments (see here)
  • Small updates to improve chandra_models access, including a change to xija so it will use ska_helpers.chandra_models.

Interface Impacts:

  • 11 packages removed.
  • parse_cm.or_list.read_or_list is deprecated. parse_cm.or_list.read_or_list_full should be used instead. Use of parse_cm.or_list.read_or_list will result in a warning.
  • xija models now will respect the CHANDRA_MODELS_DEFAULT_VERSION and CHANDRA_MODELS_REPO_DIR env vars end determine which model is used.

Testing:

There are two apparent failures in testing. Both are caused by deprecation warnings issued for using parse_cm.or_list.read_or_list. These are minor issues that will be fixed in a future release.

NOTE: in the automated changes below, the packages being removed from ska3-flight are not present. In the three other configurations, they are present in the test environment.

skare3 dashboard and test result password at https://icxc.cfa.harvard.edu/aspect/skare3_dash_cred.txt

The latest release candidates will be installed in /proj/sot/ska3/test on HEAD, and all release candidates will be available for testing from the usual channels:

conda create -n ska3-flight-2023.7rc4 --override-channels \
  -c https://icxc.cfa.harvard.edu/aspect/ska3-conda/flight \
  -c https://icxc.cfa.harvard.edu/aspect/ska3-conda/test \
  ska3-flight==2023.7rc4

Review

All operations critical or impacting PR's are independently and carefully reviewed. For other PR's the level of detail for review is calibrated to operations criticality. Some PR's that are confined to aspect-team-specific processing may have little to no independent review.

Deployment

ska3-flight 2023.7 will be promoted to flight conda channel and installed on HEAD and GRETA Linux upon approval of FSDS Jira ticket.

Code changes

All changes since the previous release

ska3-flight changes (2023.3 -> 2023.7rc4)

New Packages

  • chandra_limits: 0.5.0

Removed Packages

  • aca_hi_bgd
  • aca_weekly_report
  • acdc
  • aimpoint_mon
  • annie
  • astromon
  • jobwatch
  • kalman_watch
  • perigee_health_plots
  • ska_report_ranges

Updated Packages

  • aca_view: 0.12.0 -> 0.13.0 (0.12.0 -> -> 0.13.0)
    • PR 171 (Javier Gonzalez): Updates to dark style
    • PR 169 (Javier Gonzalez): Data improvements
    • PR 174 (Javier Gonzalez): Show AABGDTYP
    • PR 173 (Javier Gonzalez): Change log color scale so negative values are not nan
    • PR 176 (Javier Gonzalez): Dynbgd fixes
  • acis_thermal_check: 4.6.0 -> 4.7.0 (4.6.0 -> 4.7.0)
    • PR 65 (John ZuHone): Improve logging to screen and run.dat
  • agasc: 4.15.0 -> 4.16.0 (4.15.0 -> 4.16.0)
    • PR 154 (Javier Gonzalez): In agasc supplement processing, only process observations that already happened.
  • chandra_aca: 4.41.0 -> 4.42.0 (4.41.0 -> 4.42.0)
    • PR 156 (Tom Aldcroft): Convert docstrings to numpydocs format and add dark_model API docs
  • cheta: 4.59.0 -> 4.60.0 (4.59.0 -> 4.60.0)
    • PR 250 (Tom Aldcroft): Fix problems that came up in pitch/roll-comp when using real-time data
  • fot-matlab: 2.2.0 -> 2.3.0 (2.2.0 -> 2.3.0)
    • PR 21 (James Kristoff): MATLAB-12004 - parallelize star acquisition
    • PR 22 (James Kristoff): parallelized aca results
    • PR 23 (James Kristoff): fixing call args for single catalog acq path.
    • PR 24 (James Kristoff): MATLAB-12001 - SIM position states and plot do not agree with each other
  • kadi: 7.4.1 -> 7.6.0 (7.4.1 -> 7.5.0 -> 7.6.0)
    • PR 292 (Tom Aldcroft): Add validator for sun position monitor
    • PR 291 (Tom Aldcroft): Improve SPM eclipse enable state
  • mica: 4.33.0 -> 4.33.1 (4.33.0 -> 4.33.1)
    • PR 284 (Jean Connelly): Change acq anomaly notification from aca_alert to aca email
  • parse_cm: 3.10.0 -> 3.12.0 (3.10.0 -> 3.11.0 -> 3.12.0)
    • PR 41 (John ZuHone): Only use local paths for fetching the ACIS tables
    • PR 43 (Tom Aldcroft): Apply black and organize imports in acis_tables.py + update flake8 workflow
    • PR 42 (Tom Aldcroft): Add support for machine readable comments
  • proseco: 5.9.0 -> 5.10.0 (5.9.0 -> 5.10.0)
    • PR 384 (Tom Aldcroft): Make ACA penalty limit optional
    • PR 385 (Tom Aldcroft): Add test of optional ACA limits
    • PR 386 (Tom Aldcroft): Improve implementation of characteristics from ACA xija model
  • ska_helpers: 0.10.4 -> 0.11.0 (0.10.4 -> 0.11.0)
    • PR 46 (Jean Connelly): Remove extra repo from git config command
    • PR 45 (Jean Connelly): Skip git safe test on old git
    • PR 48 (Jean Connelly): Skip is_dirty check from matlab tools
  • ska_sun: 3.10.1 -> 3.11.0 (3.10.1 -> -> 3.11.0)
    • PR 24 (Tom Aldcroft): Performance
    • PR 25 (Tom Aldcroft): Support multiple sun position dispatch methods
    • PR 34 (Jean Connelly): Set to use nominal roll range 0-360
  • ska_sync: 4.10.1 -> 4.11.0 (4.10.1 -> 4.11.0)
    • PR 32 (John ZuHone): Sync ACIS tables
  • skare3_tools: 1.0.10 -> 1.1.0 (1.0.10 -> -> 1.1.0)
    • PR 99 (Jean Connelly): Update docstring to note it works on non-metapackages
    • PR 98 (Javier Gonzalez): Fixes to package info summaries
    • PR 101 (Tom Aldcroft): Add module for converting docstrings to numpydoc format
    • PR 103 (Javier Gonzalez): Requirements
  • sparkles: 4.22.2 -> 4.23.0 (4.22.2 -> 4.23.0)
    • PR 195 (Jean Connelly): Update to use more test fixtures
    • PR 193 (Jean Connelly): With dyn_bgd_n_faint option, override it in the GuideTable too
    • PR 196 (Jean Connelly): Do not use aca_t_ccd_penalty_limit via import
  • starcheck: 14.2.1 -> 14.4.0 (14.2.1 -> 14.3.0 -> 14.4.0)
    • PR 411 (Jean Connelly): Set plot ymin relative to planning not penalty limit
    • PR 420 (Jean Connelly): Downgrade bad guide data warning
    • PR 423 (Jean Connelly): Handle vehicle mode with custom filtered backstop (was PR #421)
    • PR 429 (Jean Connelly): Work with optional penalty limit in model spec
    • PR 425 (Jean Connelly): Planning t_ccd critical warning
    • PR 424 (Jean Connelly): Set 'too cold for fid placement' check to use acq t_ccd
  • testr: 4.11.3 -> 4.12.0 (4.11.3 -> 4.12.0)
    • PR 50 (Jean Connelly): Add handling for missing isatty attr on stdout
    • PR 51 (Jean Connelly): Handle StdOutWrapper class with context manager
  • xija: 4.30.0 -> 4.31.0 (4.30.0 -> 4.31.0)
    • PR 134 (Tom Aldcroft): Refactor get_model_spec to use ska_helpers.chandra_models

Related Issues

Fixes #1154
Fixes #1175
Fixes #1177
Fixes #1178
Fixes #1179
Fixes #1180
Fixes #1181
Fixes #1182
Fixes #1183
Fixes #1184
Fixes #1185

@javierggt javierggt added this to the 2023.7 milestone Sep 18, 2023
@javierggt javierggt merged commit 5700f84 into master Oct 4, 2023
20 of 21 checks passed
@javierggt javierggt deleted the 2023.7-branch branch November 20, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment